Remove draft mode — CI runs after workflow approval - #52
Merged
Merged
Conversation
…view The draft PR approach was unnecessary. PRs created by GITHUB_TOKEN require workflow approval before CI runs, which provides the human review gate without needing draft mode. Changes: - All four charm workflows: remove ready_for_review trigger type and - probe-issue.yaml: remove --draft from gh pr create, remove the PR comment about marking ready for review, update issue comment - probe_issue.py: update task instructions step 9 and run_tox scope - AGENT_DESIGN.md: update workflow flow, CI section, and remaining risks to reflect the new approach - README.md: update step 5 to say 'approve the PR workflow runs' instead of 'mark ready for review'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The draft PR approach was unnecessary. PRs created by
GITHUB_TOKENrequire workflow approval before CI runs, which provides the human review gate without needing draft mode.Changes
probe-issue.yaml: removed--draftfromgh pr create, removed the PR comment about marking ready for review, updated issue commentprobe_issue.py: updated task instructions step 9 and run_tox scope descriptionAGENT_DESIGN.md: updated workflow flow, CI section, and remaining risksREADME.md: updated step 5 — review the PR first, then approve workflow runs to trigger CIVerification
uvx ruff format— passesuvx ruff check— passesuvx ty check— passes