Repository navigation
Issue sprint: theme editor, motion and layout, tear-off tabs, Informix row history, test data generator - #173
Conversation
…h live preview, contrast checks and JSON export/import (#107) Every token is editable by group (surfaces, text, borders, accent, states, grid, editor syntax, explorer, Gib), plus fonts, radius, row height, shadows and animation speed. Custom themes sit next to the built-in ones, can be chosen for the system's light and dark modes, and tear-off windows follow them through the shared settings. Hard-coded corner radii now use the radius tokens so the radius setting reaches every component. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ons, shared component states, F6 between panels and one drag-and-drop look (#110) Every transition and animation takes --motion-fast/normal/slow (scaled by the theme's speed, cut by reduced motion); dev/motion-check.ts fails on a stray duration. Panels, tabs, toasts, dialogs, menus and the palette animate in and out, buttons share hover and press, text fields one focus ring, menus and popovers one surface, badges and empty states one style. F6 / Shift+F6 move the focus between panels, context menus show shortcuts from the keymap in one notation, and tabs, result columns, explorer and library share the drag tokens and ghost card. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…he new window's outline, and tab bars show where it lands (#108) The drag image is a card with the tab's title, connection and first lines. Outside every Celer window the core shows a transparent, click-through outline window (public/drag-ghost.html) at the very spot the new window will open, with «Soltar para abrir en una ventana nueva»; over a window it hides and that window's tab bar draws an insertion line (also for reordering within a bar). The tab menu says «Abrir en ventana nueva», the tooltip mentions dragging, a one-time hint (Gib or a notice) explains it, and a window opened by a drop grows into place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… or the guide is on top (#110) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… which threw DataCloneError on store proxies and kept saved themes from opening (#107) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…speed (#110) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… image no longer shows over it, and a dropped window is kept on the screen (#108) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…eler window too (#108) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…y precondition and partial reason said (#123) Brings wip/informix-row-history-2.3 up to main as one change and fixes what Sprint 2.3's testing found: - A transaction is named by the log position of its commit; the records' transaction number is a reused slot. - A read stopped or cut short shows how far it got and never says «sin cambios»; a connection lost mid-read (killed session, server restart) keeps what was read, labelled partial, instead of failing the dialog. - No-changes text no longer infers the row's earlier values. - Fixed-length-only tables: the full-row-logging offer says earlier updates will not appear, and a history read with it turned on just for the read is labelled partial; tables with a VARCHAR are told their changes read whole. - DRDA and Client SDK are preconditions of the connection: the entry stays enabled on Informix and the dialog says «No se puede reconstruir: la conexión usa DRDA…». Other engines keep it disabled with «No disponible en …». - The row menu entry follows main's greyed-out convention (hint and tooltip); no shared menu component changes. - CHANGELOG entry under [Unreleased]. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…will open, kept on its monitor, and Esc leaves the tab where it was (#108) Sprint 2.3 failed here: dragged into the lower half of a large screen, the fixed 1280x820 outline hung off the bottom with its label, while the dropped window opened clamped somewhere else. Now one frame (drop_frame in windows.rs) places both: the full window's size at the scale of the monitor under the pointer, its corner at the drop offset, kept inside that monitor's work area. The outline resizes when it crosses to a monitor with another scale, and a dropped window is sized and placed again after landing there. The label sits at the top of the outline, next to the pointer. On Windows the core watches the mouse button and Esc while the system runs the drag: the outline goes the moment the button is let go or Esc is pressed, the window opens where the button was let go (not where the pointer is a moment later), and Esc no longer opens a window. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rir en ventana nueva» and describe the outline (#108) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… the tail of the current log with one log switch, as a DBA would, instead of failing on the server's state (#123) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n Entorno row and grouped settings, as approved (#111) - Context menus take submenus (MenuItem.submenu): arrows, → / Intro open one with its first item active, ← / Esc go back, the mouse opens one by resting on its row; a submenu sits beside its row and flips or moves to stay in the window (src/menu.ts, dev/menu-check.ts). - The top bar loses its explorer button (the stripe and Alt+1 stay). The right panel's header keeps only Valor / Registro, or the title of the tool open (Historial, Biblioteca, Variables, Asistente IA), which open from the stripe (Variables gets its button there) and their shortcuts. - One «Importar conexiones ›» (fichero de Celer · DBeaver · DbVisualizer) in Nuevo and in the explorer's options menu; the background menu keeps only the order. Palette commands for each import and for exporting every connection. - Tables and views: open, structure, «Ver DDL» and diagram on top, then «Generar SQL ›» (eight entries for a table, four for a view) and «Comparar ›»; «DDL en consola» is the DDL tab's «Abrir en consola», which now opens on the table's database. - Cell menu: Copiar, Copiar con cabeceras, «Copiar como ›» (CSV, JSON, Markdown, XML, INSERT, IN, WHERE) and «Filtrar ›», each running what its entry ran before. - Connection dialog: environment, Solo lectura and Color framed as one Entorno row below the main block. - The palette's «Editor de tema…» opens its section in Ajustes. - The welcome tour, Gib's tip, the e2e helpers (menu paths through submenus) and dev/layout-check.mjs (the whole walk on the browser preview) follow. The split button Siguiente página / Cargar todo was not done, as decided. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ont or an out-of-range number is refused with what is wrong instead of being imported silently cleaned (#107) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…unsaved, so leaving, importing or switching asks only when there is something to lose (#107) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…he open results, so text no longer spills into the next column until the query is rerun; hand-resized columns keep their width (#107) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…showed: its size is measured and asked again (the first resize of a new undecorated window added a title bar, 30 px taller) and its corner moved by the invisible shadow frame (8 px off), so a drop near the bottom no longer leaves it under the taskbar (#108) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ion Windows shows the move cursor instead of its no-drop sign on top of «Soltar para abrir en una ventana nueva» (#108) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e he is there, instead of in whichever window hosts him (#108) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n use, the one a click changes, not the global one (#107) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er window (#108) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…pop-in still scales it down, so one opened at the window's right edge no longer overflows it (#110) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…sing the start-up guide, so on a cold dev server the guide no longer opens mid-check and takes the Esc meant to close the menu (#111) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…its tab (the offset is scaled to the monitor), and moved onto a monitor with another scale it is placed before it is sized and measured again, so the system's rescale no longer leaves it a different size from the window that opens (#108) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…alid rows on every engine (#172) A dialog from the table's menu (explorer and tab) and the palette proposes a generator per column from its type and its Spanish or English name, reads the table's unique keys, CHECK lists and ranges, native enums, identity columns and foreign keys (with a sample of the referenced keys) per dialect, and generates reproducible rows (seed) with a 20-row preview. The rows go in through the import's pipeline (now a shared insertInTransaction: own session, one transaction, progress, rows/s, Cancelar rolls back; read-only refuses, production asks), or to a script in a new console (a file past 10,000 rows), or to CSV / JSON. An empty referenced table is offered to be filled first. Import: 0x… values go into binary columns as bytes. Pure logic in src/testData*.ts (dev/testdata-check.ts); per-dialect SQL checked live on PostgreSQL, MySQL, MariaDB, SQL Server, Informix (DRDA and JDBC), SQLite and ODBC by engine_tests.rs testdata_* (10,000 rows, count, FK integrity, uniqueness, lists and ranges, a row read back, rollback, another session's open transaction), plus 100,000 rows into PostgreSQL; dev/testdata-e2e-check.mjs drives the dialog in the desktop app. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ancelled (#172) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…site primary keys get a value from the test data generator, the grid and the import (#172) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… ones) runs the connection's startup script first, as its sessions do, and a read-only connection refuses a script that writes; engine test on Informix JDBC with a broken and a good script (#180) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…r instead of a bare comma without BOM, so accented test data opens correctly in Excel (#204) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… saving a test-data script or export of tens of MB no longer freezes every window (#207) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…gging Celer turned on, and only the last of them turns it off, instead of the first to end turning it off under the others; engine test with two overlapping reads on Informix JDBC (#205) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…a read whose newest log part the CDC API did not have ready yet, and the large-schema keys bound is timed again when the first read hits a catalog cold from the container restart, so the Informix gate no longer fails intermittently (#206) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… existing values of unique columns are indexed once per model, so editing the dialog's settings on a table with 200,000 rows no longer freezes the window, and closing the dialog releases them (#184) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ough an append-capable write_text_file and a new finish_text_file, so a 1,000,000-row JSON of a wide table no longer fails with «Invalid string length», and a cancelled run leaves no partial file (#185) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…g inserted no longer cancels the run and rolls back the transaction; only the footer's Cancelar / Detener stops it, as in the export dialog (#186) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… back as the user left it (rows, seed, language, output, view and each still-existing column's generator) instead of resetting it (#208) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…y that to the other windows, instead of a console's full SQL text through the core (#209) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, plus the editor, result compare, typed import and windows e2e scripts, and STATUS states the current test counts (282 / 35 / 28) (#212) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…r, Informix row history and tear-off outline, and list Alt+1 and F6 / Shift+F6 among the shortcuts (#213) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…uild, so they show the top bar without the explorer button and the stripe with its Variables button (#214) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… gets its Fixed entry, since it changes the structure view, schema comparison and diagram as well as the test data dialog (review follow-up) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Release gate: not passedChecked on head
What is needed to pass
Version bump once it passes: minor (features #107, #108, #110, #111, #123, #172). |
…ed and no longer remembered for the session, and the engine test stops racing them (#123, #206) About 90 s after Informix starts, the sysadmin scheduler's start-up sensors (mon_sysenv, mon_config_startup) write a burst of transactions to the log, and the CDC reader stops where it meets them for minutes. The engine test restarted the container first, so on the slower CI runner its reads ran into that window: every later history was partial, ask_whole's retries jumped to new logs the reader did not deliver, a cdc_deactivatesess went unanswered, and since the test reused one connection for every read the next cdc_opensess was refused (-83715). That history was "unavailable" with its reason, but the assertion only printed its empty op list. - rowhistory: the stop message names both causes and says to read again later; a wall found by one read is trusted for five minutes only (the reader was measured to read past it again). - engine test: waits for the start-up sensors, reads a short probe history and restarts the container only when the reader does not give it whole (no restart of a shared server otherwise), reads each history on its own connection as the app does, refuses an unavailable history with its reason, prints the history on failure, and runs the two simultaneous reads last. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Release gate: not passedChecked on head
What is needed to pass
Version bump once it passes: minor. |
… keeps its own changes instead of having them dropped as a dropped table's (#123) After an unclean stop before the checkpoint that followed a CREATE TABLE, fast recovery replays it on start and stamps sysptnhdr.created with the replay time. The history took that as the creation time, skipped the logs before it and discarded the row's real insert and updates as «de una tabla borrada que tenía el mismo número de partición». A creation time between the server's start (sh_boottime) and its on-line mode (the Startup checkpoint in syscheckpoint, else the first internal session) is now taken as the replay's: nothing is skipped or discarded by time, the changes are shown, and the history is partial with the true reason. A part of the log the CDC API then refuses (-83800 on the first insert, seen once) is said as a gap, and no gap lets the history claim where the row began. The engine test reproduces it with docker kill, only with CELER_INFORMIX_KILLABLE=1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…on time was rewritten by Informix fast recovery, with the true partial reason (#123) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Release gate: not passedChecked on head
What is needed to pass
Version bump once it passes: minor. |
…n time, changes before it are left out with the true reason instead of a dropped table's being listed as the row's (#123) 5b8fb74 read every log from the start when sysptnhdr.created fell between the server's start and its on-line mode, and listed every earlier commit as the table's: a dropped table that had the same partnum (even the server's set-up records) showed up as the row's own inserts and updates. The read now keeps the normal cutoff at that creation time and the history says why it is partial: «El servidor reescribió la hora de creación de esta tabla al recuperarse de una parada brusca (…): los cambios anteriores a esa hora no se pueden atribuir a esta tabla con seguridad y no se muestran.» It never calls them a dropped table's, never says the row had no changes or where it began; the dialog's empty state says no change was read since that time (new History.shownFrom). Changes after the recovery are shown. The detection, the -83800 gap and the start-up log note are kept. The engine test creates and drops tables of the same name first (their partnum is reused), kills the server and checks that nothing before the recovery is listed and that an update after the restart is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…y shows nothing it cannot attribute and says why (#123) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Release gate: passedChecked on head
Observation (not blocking, older than this fix): on a table whose read starts after older logs that are still on disk, the range line says «Lo anterior ya no está en los logs». The note just below gives the real reason («La lectura empieza en el log 6: los anteriores se llenaron antes…»). This line also shows for normal tables and was in the earlier passing gates. It could be reworded in a later low-severity issue. Version bump: minor (2.4.0 has features). |
Integration of the 2.4.0 issue sprint: three tested branches merged with
--no-ffontomain, plus two integration fixes.issue/theme-motion-layoutissue/informix-row-historyissue/test-data-generatorIntegration (this branch)
CHANGELOG.md,engine_tests.rs,commands.ts,Modals.tsx,Workspace.tsxandSidebar.tsx. Feature review: reorganise and simplify overgrown parts (no features removed) #111 moved the eight Generar … entries into Generar SQL ›. Test data generator: fill a table with realistic, valid data on every engine #172 had put Generar datos de prueba… among those entries, so it is now a top-level table-menu entry next to Exportar datos… / Importar datos…. That keeps the Generar SQL › submenu at the eight entries Feature review: reorganise and simplify overgrown parts (no features removed) #111 specifies. The table tab menu and the palette are unchanged.Integration:7ca9cf6: the row history and test data dialogs had hard-coded radii (8/6/10 px) and their own focus ring, andthemes-checkfailed on them after the merge. They now use--radius-sm/mdand--focus-shadow, so custom themes and the high-contrast focus ring reach them.Integration:bc294c5:dev/motion-check.tsbuiltC:\C:\…fromURL.pathnameon Windows, socheck-all.ps1failed there. It passed in WSL. The path now comes fromfileURLToPath.Checks on the integrated head
Fast checks (WSL): every
dev/*-check.tspasses;tsc --noEmit -p .and-p installerpass;npm run buildpasses.bash dev/wsl/engines.sh testat 7ca9cf6 printed ALL ENGINES PASS (exit 0). Results by engine:Other modules: rowhistory 15, windows 7 and ssh 4. Zero failures; 1 ignored in sheets, as before.
bc294c5 changes only a dev check.
dev\check-all.ps1at 7ca9cf6 (Windows, debug desktop app): every step passed except these four.layout-check.mjspassed 31/31, with no page errors.Execution context was destroyedwhile the app was starting. That is a start-up reload; verify failed only because prepare had not run. I ran restart → prepare → restart → verify again twice and it passed both times (5/5 ok).The e2e steps passed, including test data generator, generated scripts, data/schema comparison, keyboard shortcuts (desktop) and Gib companion.
#107 Theme editor: full visual customisation
What changed: Ajustes › General › Editor de tema (also the palette entry and the pencil on a custom card) builds a custom theme from any built-in one:
.celer-theme.jsonexport and import (hostile, garbage or newer files are refused);Tests (desktop slot 1; no connection involved):
#110 Global animations and styles
What changed:
Tests:
#108 Tear-off windows: make dragging a tab out obvious
What changed:
Tests:
windows::7 ok.#111 Reorganise overgrown parts (nothing removed)
What changed:
Tests:
#123 Informix row history from the logical logs
What changed: Historial de la fila in a table viewer's row menu on Informix over JDBC reads the row's changes from the logical logs through the CDC API, newest first:
Tests (desktop slot 2):
invoke); the SDK is not installed here.informix_jdbc_row_history, rowhistory 15 and rowhistory-check pass.Known non-blocking nits (follow-up):
INFORMIX_GUIDE:code prefix in the error box.#172 Test data generator
What changed: Generar datos de prueba… opens from the table menu (explorer and tab) and the palette.
0x…into binary columns as bytes.Tests (desktop slot 3):
testdata_*passes on every engine; the browser demo works.Closes #107
Closes #110
Closes #108
Closes #111
Closes #123
Closes #172
Issues left out: none.
Review
Macro review 2.4 (
/macro-review full, all areas, focused on the 2.4 features; tracking issue #171). The full report is indocs/review/REPORT.md.41 issues filed (1 high, 13 medium, 27 low). All 41 are fixed on this branch: none deferred, none left open. The final verification is green, with no failures and no regressions.
#180 was filed by three auditors (drivers-enterprise, connections, core-rust) and is counted once. It was fixed in two parts: the SSH tunnel (23699b6) and the startup script (025c421).
Not fixed, and outside these issues: with the Teal or Green accent, accent-coloured text stays below 4.5:1 in the light themes.
What the review did not check (the full list is in the report):
Final engine matrix (whole branch)
These results come from the latest
bash dev/wsl/engines.sh testrun (the WSL side ofdev\wsl.ps1 test). It ran on the branch's final code, 13 Oct 09:09. The commits after it change only docs, screenshots, CHANGELOG anddev/check-all.ps1. First run: 281 passed, 0 failed, 1 ignored (sheets). MariaDB rerun: 29 passed. The run printed ALL ENGINES PASS, exit 0.Other modules: engine_tests 62, rowhistory 17, windows 7, report 5, write_text_tests 1 and data_dir_tests 1. All pass.
Fast checks pass on every area: all 35
dev/*-check.ts,tsc -p .,tsc -p installerandnpm run build.GitHub Actions on this head:
ci.yml,engines.yml(SQL Server + Informix) and a manualrelease-desktop.ymlpackages-only run (Windows/macOS/Linux,celer-releaseartifact, nothing published) have been triggered.Review issues closed by this PR
Closes #174
Closes #175
Closes #176
Closes #177
Closes #178
Closes #179
Closes #180
Closes #181
Closes #182
Closes #183
Closes #184
Closes #185
Closes #186
Closes #187
Closes #188
Closes #189
Closes #190
Closes #191
Closes #192
Closes #193
Closes #194
Closes #195
Closes #196
Closes #197
Closes #198
Closes #199
Closes #200
Closes #201
Closes #202
Closes #203
Closes #204
Closes #205
Closes #206
Closes #207
Closes #208
Closes #209
Closes #210
Closes #211
Closes #212
Closes #213
Closes #214
🤖 Generated with Claude Code