Skip to content

Single results file - #695

Merged
AlexanderKaran merged 7 commits into
mainfrom
single-results-file
Oct 27, 2026
Merged

AlexanderKaran merged 7 commits into
mainfrom
single-results-file

Conversation

@AlexanderKaran

Copy link
Copy Markdown
Collaborator

Ok to review this PR you need to first review:

This PR builds on both, but the basic idea is to stop duplicating the JSON files both in app/starter packages and then again in the docs.

  • The first commit for this PR is cleaning up JSON files and moving them into the results package (does not really need reviewing but here is the commit 80c7384)

The second commit is the one that needs reviewing a9bd08a

  • import results pacakge into the docs package
  • Seperate all data prep from its components
  • Remove all duplication validation and collection wrappers
  • Remove usless helpers, types and schemas no longer needed
  • Charts and tables still preserve the same order and set up

There will still need to be one final clean up PR after this

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
framework-tracker a8d6ab3 Commit Preview URL

Branch Preview URL
Oct 27 2026, 01:54 AM

@dreyfus92 dreyfus92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🧹

@AlexanderKaran
AlexanderKaran merged commit 768d661 into main Oct 27, 2026
5 checks passed
@AlexanderKaran
AlexanderKaran deleted the single-results-file branch October 27, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants