Repository navigation
Added Variance Check - #706
Merged
Merged
Conversation
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
framework-tracker | 8d31880 | Commit Preview URL Branch Preview URL |
Oct 27 2026, 12:49 PM |
43081j
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brought Variance back as a top-level variable. So every time a full run of a benchmark happens, and we re-create its top level result we add a
variancekey that compares it to the last version, like so:{ "name": "coldBuild", "runs": 5, "iterations": [ { "timeMs": 955 }, { "timeMs": 930 }, { "timeMs": 925 }, { "timeMs": 936 }, { "timeMs": 967 } ], "timeMs": { "mean": 942.6, "median": 936, "min": 925, "max": 967, "variance": { "comparedToMeasuredAt": "2026-10-27T03:16:33.289Z", "meanPercent": -9.10, "medianPercent": -1.89, "minPercent": 3.24, "maxPercent": -29.88 } } }Only compares if the versions are the same. Then, when the stats PR is generated, a special CI/CD check runs; if any of the benchmark results are bigger than a 10% swing, it flags it to re-run the test.
We can, of course, lower this number and later configure different values per benchmark. Not storing historical data for now just compare the current one each time until you bump versions