Repository navigation
fix(docs): use the median run for interaction tables and comparison - #724
Merged
Merged
Conversation
43081j
approved these changes
Oct 29, 2026
AlexanderKaran
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since the switch to median, the interaction phases were each their own median, which don't add up to the median total. the comparison bars stopped short of their total label and the tables didn't add up (solidstart: 17.88ms total vs 14.70ms of phases).
now
formatRenderedpicks the run whose total is the median and uses its phases, so they add up exactly and the total stays the same median. the framework page chart was already doing this on its own, so that copy is gone and everything reads from the one place.only the run-time and all-results pages change, totals are identical to main and the framework pages are byte-identical.