Skip to content

docs: add reason lines to the rollup-plugin-terser, tsup and cpx docs - #1150

Merged
43081j merged 2 commits into
mainfrom
add/mr-049
Oct 23, 2026
Merged

43081j merged 2 commits into
mainfrom
add/mr-049

Conversation

@dreyfus92

Copy link
Copy Markdown
Member

🔗 Linked issue

no issue, follows up #1149

📚 Description

adds the reason line under the title of rollup-plugin-terser, tsup and cpx

for tsup i quoted the readme instead of calling it unmaintained since 9.0.0 came out last week

@ghostdevv ghostdevv left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps for clarity it should be like

**Motivation:** reason

or

## Motivation

reason

Comment thread docs/modules/cpx.md Outdated
Co-authored-by: Willow (GHOST) <git@willow.sh>
@dreyfus92

Copy link
Copy Markdown
Member Author

Perhaps for clarity it should be like

**Motivation:** reason

or

## Motivation

reason

i like the idea, but it would change the convention we agreed on in #1149, which only has a plain line under the title. so i'd rather keep this pr as is and do the switch in a follow up pr that updates the template, contributing and the docs we've done so far

@ghostdevv @43081j which one do you prefer, **Motivation:** reason or a ## Motivation heading? i lean towards the inline label since a heading might look like another replacement next to the other ## ones, but happy to go either way

@gameroman gameroman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good

@43081j

43081j commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

i'd just bold it but not as part of this PR, let's tackle that in its own issue 👍

@43081j
43081j merged commit 418c31a into main Oct 23, 2026
4 checks passed
@43081j
43081j deleted the add/mr-049 branch October 23, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants