Repository navigation
feat(preferred): add classnames to replacements - #1151
Merged
Merged
Conversation
43081j
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Closes #1148
📚 Description
This adds
classnamesto the preferred manifest withclsxas the replacement, plus a docs page.clsxtakes the same strings, objects, arrays and falsy values, so for most code the swap is just the import. I ran both packages (classnames 2.5.1, clsx 2.1.1) side by side on a set of inputs: plain strings, objects, nested arrays, numbers,null/undefined/false, and duplicate names. They gave the same output everywhere except objects with a customtoString(). classnames calls it, while clsx treats the object as a class map. The docs page mentions that, along with the missingdedupe/bindvariants and theclsx/liteentry point.Checked locally with
pnpm lint:manifests,prettier --checkon the changed files andpnpm build. Both packages are well above the download threshold (about 19M and 76M per week).