Skip to content

[20274] Remove default port value in yaml address field - #193

Merged
Danipiza merged 2 commits into
mainfrom
feature/yaml_validator_v2
Aug 6, 2026
Merged

Danipiza merged 2 commits into
mainfrom
feature/yaml_validator_v2

Conversation

@David-LP99

Copy link
Copy Markdown
Contributor

As part of the PR eProsima/DDS-Router#543, a few changes are needed in the Pipe to enforce the requirement of having a port tag as part of every element of listening-addresses and connection-addresses, in the Yaml configuration of the Discovery Server and Initial Peers participants.

The changes consist on throwing an exception when no port tag is present instead of assigning the default value, and updating the involved tests to account for this.

Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
@Danipiza
Danipiza self-requested a review August 4, 2026 08:54

@Danipiza Danipiza left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Danipiza
Danipiza merged commit 09a1f4e into main Aug 6, 2026
70 of 77 checks passed
@Danipiza
Danipiza deleted the feature/yaml_validator_v2 branch August 6, 2026 10:30
@Danipiza Danipiza added this to the v1.5.2 milestone Aug 20, 2026

This branch was previously deployed

1 inactive deployment
codecov — 8482054d Deployed Jul 17, 2026 by David-LP99 via reusable_tests / coverage #1516
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants