Skip to content

[25750] Load types from IDL files in the dynamic types participants - #205

Merged
Danipiza merged 6 commits into
mainfrom
feature/load-types-from-idl
Nov 13, 2026
Merged

Danipiza merged 6 commits into
mainfrom
feature/load-types-from-idl

Conversation

@ZakariaTalbi

Copy link
Copy Markdown
Contributor

Check whether the fastdds version in use is equal or greater than 3.4 and, if so, allows to load multiple types from IDL files into the dynamic types participants

@ZakariaTalbi
ZakariaTalbi marked this pull request as draft October 15, 2026 13:06
@ZakariaTalbi ZakariaTalbi added this to the v1.6.0 milestone Oct 15, 2026
@codecov-commenter

codecov-commenter commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 13.15789% with 99 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.86%. Comparing base (e9c1e26) to head (0794b16).

Files with missing lines Patch % Lines
...cpp/participant/dynamic_types/dyn_types_common.cpp 0.00% 32 Missing ⚠️
ddspipe_participants/src/cpp/utils/idl_types.cpp 44.11% 4 Missing and 15 partials ⚠️
...ts/src/cpp/participant/dynamic_types/idl_types.cpp 0.00% 16 Missing ⚠️
.../participant/dynamic_types/DynTypesParticipant.cpp 0.00% 13 Missing ⚠️
...rticipant/dynamic_types/XmlDynTypesParticipant.cpp 0.00% 12 Missing ⚠️
ddspipe_yaml/src/cpp/YamlReader_participants.cpp 0.00% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   41.07%   40.86%   -0.22%     
==========================================
  Files         161      164       +3     
  Lines        7651     7721      +70     
  Branches     3062     3099      +37     
==========================================
+ Hits         3143     3155      +12     
- Misses       2794     2832      +38     
- Partials     1714     1734      +20     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juanlofer-eprosima juanlofer-eprosima left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done mate, you are rocking it! 🥇

The one suggestion I would make is to move the IDL types loading logic to where it is actually needed, there is no need to reuse the discovery path used up to now. What we need to decide is which type has more priority: the one received via discovery, or the one the user explicitly loaded. We should be bringing topics such as type evolution into the discussion to make the right decision.

@Danipiza Danipiza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>
Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>
Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>
Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>
Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>
Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>

@Danipiza Danipiza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Danipiza
Danipiza marked this pull request as ready for review November 13, 2026 11:44
@Danipiza
Danipiza requested review from juanlofer-eprosima and removed request for juanlofer-eprosima November 13, 2026 11:45
@Danipiza
Danipiza merged commit b230678 into main Nov 13, 2026
39 checks passed
@Danipiza
Danipiza deleted the feature/load-types-from-idl branch November 13, 2026 11:46

This branch was previously deployed

1 inactive deployment
codecov — 0794b163 Deployed Nov 11, 2026 by ZakariaTalbi via reusable_tests / coverage #1586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants