Repository navigation
[25750] Load types from IDL files in the dynamic types participants - #205
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
- Coverage 41.07% 40.86% -0.22%
==========================================
Files 161 164 +3
Lines 7651 7721 +70
Branches 3062 3099 +37
==========================================
+ Hits 3143 3155 +12
- Misses 2794 2832 +38
- Partials 1714 1734 +20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ZakariaTalbi
force-pushed
the
feature/load-types-from-idl
branch
from
October 15, 2026 13:56
c16e70b to
017f468
Compare
juanlofer-eprosima
requested changes
Oct 16, 2026
ZakariaTalbi
force-pushed
the
feature/load-types-from-idl
branch
from
October 21, 2026 12:45
fc65b91 to
cf34fcb
Compare
juanlofer-eprosima
previously requested changes
Oct 22, 2026
juanlofer-eprosima
left a comment
Contributor
There was a problem hiding this comment.
Well done mate, you are rocking it! 🥇
The one suggestion I would make is to move the IDL types loading logic to where it is actually needed, there is no need to reuse the discovery path used up to now. What we need to decide is which type has more priority: the one received via discovery, or the one the user explicitly loaded. We should be bringing topics such as type evolution into the discussion to make the right decision.
Danipiza
requested changes
Nov 6, 2026
Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>
Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>
Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>
Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>
Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>
Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>
ZakariaTalbi
force-pushed
the
feature/load-types-from-idl
branch
from
November 11, 2026 10:04
112df06 to
0794b16
Compare
Danipiza
marked this pull request as ready for review
November 13, 2026 11:44
Danipiza
requested review from
juanlofer-eprosima
and removed request for
juanlofer-eprosima
November 13, 2026 11:45
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check whether the fastdds version in use is equal or greater than 3.4 and, if so, allows to load multiple types from IDL files into the dynamic types participants