Repository navigation
Conversation
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
- Coverage 41.07% 40.85% -0.23%
==========================================
Files 161 164 +3
Lines 7651 7723 +72
Branches 3062 3099 +37
==========================================
+ Hits 3143 3155 +12
- Misses 2794 2834 +40
- Partials 1714 1734 +20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, two threads could do this concurrently:
Callback registration/removal used the BaseReader mutex, but reception and dispatch used the queue mutex. Those different locks did not protect the callback’s lifetime. That is why your original probe still reported true.
Fix
Holds the BaseReader mutex through callback dispatch, making disable/removal wait for an active invocation.