Repository navigation
[25748] Option to leave out wide characters and strings - #352
Open
emiliocuestaf wants to merge 3 commits into
Open
emiliocuestaf wants to merge 3 commits into
emiliocuestaf wants to merge 3 commits into
Conversation
emiliocuestaf
force-pushed
the
feature/fastcdr-face-wstrings
branch
from
October 30, 2026 16:01
7109d2f to
89e6bf8
Compare
emiliocuestaf
force-pushed
the
feature/fastcdr-face-wstrings
branch
from
October 30, 2026 17:21
89e6bf8 to
16b1144
Compare
emiliocuestaf
added a commit
that referenced
this pull request
Nov 3, 2026
utils/face/check_face.py compiles Fast CDR as the FACE Conformance Test Suite compiles a Unit of Conformance: each public header alone and each source, with the compiler flags of the CTS toolchain and only the gold standard headers of the profile. Then the functions the objects use must be defined by the gold standard libraries, built from their CTS sources, the default allowed definitions of the CTS, or allowed_symbols.txt (the C++ exception runtime). It lists every issue where it is, with the files that run into it, and fails when there is any. Only the gold standard files are fetched from the CTS 3.2.3 archive, with HTTP range requests (10 MB), and checked against their SHA-256. FASTCDR_FACE_TEST (GCC on Linux, OFF by default, since it needs network access) adds it as the CTest test FaceGeneralPurpose, which the Ubuntu CI runs. It fails until wide strings can be left out (#352): the profile excludes them. Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
emiliocuestaf
force-pushed
the
feature/fastcdr-face-wstrings
branch
2 times, most recently
from
November 3, 2026 18:08
fe705de to
a0bbed1
Compare
emiliocuestaf
force-pushed
the
feature/fastcdr-face-wstrings
branch
from
November 5, 2026 15:57
a0bbed1 to
47a03e7
Compare
10 of 13 tasks
FASTCDR_DISABLE_WSTRINGS (CMake option, defined in config.h) leaves wchar_t and std::wstring out of the API of Cdr, FastCdr and CdrSizeCalculator, for standard libraries that do not provide them. The tests that use them are left out with it, and the complete tests serialize the wide types in a block of their own. A CI job builds and tests with the option on. Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
The FACE CI job configures Fast CDR with FASTCDR_DISABLE_WSTRINGS: the C++11 General Purpose capability set excludes wide characters and strings, so that is the configuration a FACE application uses. Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
emiliocuestaf
force-pushed
the
feature/fastcdr-face-wstrings
branch
from
November 13, 2026 12:13
47a03e7 to
36334eb
Compare
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A new CMake option,
FASTCDR_DISABLE_WSTRINGS(defaultOFF, defined to 0 or 1 inconfig.h), leaves the wide characters and strings out of the API, for standard libraries that do not provide them: everywchar_tandstd::wstringoverload ofCdr,FastCdrandCdrSizeCalculator, and their definitions.With the option
OFFnothing changes. With itON, the tests that use wide types are left out. The complete tests now serialize the wide types in a block of their own after the rest (the string sequence moved before them), in both modes.A new CI job builds and tests with the option on: 1948 tests pass with it, and 2124 without it.
The FACE check job added by #351 now configures Fast CDR with
FASTCDR_DISABLE_WSTRINGS=ON: the C++11 General Purpose capability set excludes wide characters and strings, so that is the configuration a FACE application uses, and the check passes with it.This PR depends on #351 and must be merged after that one.
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist