Skip to content

Support try_construct on optionals and externals - #355

Merged
richiware merged 2 commits into
masterfrom
feature/try_construct_optional_external
Nov 11, 2026
Merged

richiware merged 2 commits into
masterfrom
feature/try_construct_optional_external

Conversation

@richiware

@richiware richiware commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware added this to the v2.5.0 milestone Nov 11, 2026
@richiware
richiware requested a review from Danipiza November 11, 2026 09:28
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
richiware requested review from Danipiza and removed request for Danipiza November 11, 2026 09:51
Comment thread include/fastcdr/Cdr.h Resolved

@Danipiza Danipiza left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware
richiware merged commit c781654 into master Nov 11, 2026
16 checks passed
@richiware
richiware deleted the feature/try_construct_optional_external branch November 11, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants