Skip to content

Fix CLI testing in installer - #6625

Open
cferreiragonz wants to merge 1 commit into
masterfrom
fix_windows_cli_testing
Open

cferreiragonz wants to merge 1 commit into
masterfrom
fix_windows_cli_testing

Conversation

@cferreiragonz

@cferreiragonz cferreiragonz commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR introduces a workaround to avoid an error in MSCV x86.

@Mergifyio backport 3.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
@cferreiragonz cferreiragonz added this to the v3.6.3.0 milestone Nov 12, 2026
@cferreiragonz
cferreiragonz requested review from richiprosima and removed request for richiprosima November 16, 2026 06:51
@github-actions github-actions Bot added the ci-pending PR which CI is running label Nov 16, 2026
@emiliocuestaf
emiliocuestaf self-requested a review November 16, 2026 11:41

@emiliocuestaf emiliocuestaf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants