bug fix: honor customOSType instead of overwriting with platform OS. - #215
Open
jinanzhuan wants to merge 4 commits into
Open
bug fix: honor customOSType instead of overwriting with platform OS.#215jinanzhuan wants to merge 4 commits into
jinanzhuan wants to merge 4 commits into
Conversation
…ction) After merging branch_unity_agora_1.4.0 (easemob#216), muteList was inconsistent: - C++ (models.cpp) still output JSON Array - C# (Group.cs / Room.cs) parsed JSON Object -> List<string> This commit aligns with the agora fix direction (Object + Object-parse): - C++ Group::ToJsonObject(EMMucMuteList): revert to Object output - Keeps the agora-introduced C# parsing (Object -> extract keys) - This matches the Android native SDK format (Map<String, Long>) - Public API unchanged: Group.MuteList / Room.MuteList still List<string>, GetGroupMuteListFromServer / FetchRoomMuteList still Dictionary<string, long> Also restore SdkVersion to 1.4.1 (was accidentally downgraded to 1.4.0 by agora's d94eb10 'update agorachat version to 1.4.0').
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.