Repository navigation
Keep the pending-acks gauge alive as long as the poller - #57
Merged
Merged
Conversation
Micrometer refers to what a gauge reads weakly, and SsfPoller handed it a fresh method reference on every start that nothing else held on to. After a garbage collection the easyssf.receiver.poll.pending-acks gauge read NaN; the JDK 27 job of the CI collected it first. The poller now keeps the supplier in a field, so the gauge lives exactly as long as the poller, and the metrics javadoc states that contract. The test provokes a collection and proves it happened through a weak reference of its own, as System.gc() is only a hint. Fixes #56 Signed-off-by: Thomas Darimont <thomas.darimont@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Micrometer refers to what a gauge reads weakly, and SsfPoller handed it a fresh method reference on every start that nothing else held on to. After a garbage collection the easyssf.receiver.poll.pending-acks gauge read NaN; the JDK 27 job of the CI collected it first. The poller now keeps the supplier in a field, so the gauge lives exactly as long as the poller, and the metrics javadoc states that contract.
The test provokes a collection and proves it happened through a weak reference of its own, as System.gc() is only a hint.
Fixes #56