Repository navigation
fix(editor): make TextareaAutocomplete fully controlled to prevent update loops - #1940
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
In
apps/web/src/features/shared/textarea-autocomplete/index.tsx, removed the duplicated localvaluestate and theuseEffectthat kept re-syncingprops.valueinto it.TextareaAutocompleteis now fully controlled: it passesprops.value ?? ""straight down toReactTextareaAutocompleteand forwards change events viaprops.onChangewithout updating local state.Why
TextareaAutocompletemaintained a localvaluemirror initialized fromprops.value, and ran:Because the local
valuewas included in the dependency array, any edit (e.g. typing or pasting an image, which dispatches a syntheticchangeevent frominsertOrReplace) calledsetValue(event.target.value)insidehandleChange, immediately re-triggering the effect to writeprops.valueback. In callers like/submitand the comment reply box—where the parent already holds controlled state (body/text)—the ping-pong between local state and the incoming prop produced back-to-back synchronous updates that exceeded React's maximum update depth (error #185).Making the component purely controlled removes the redundant state copy and eliminates the update loop entirely.
Fixes ECENCY-NEXT-1GRK
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.