fix(core-tracing): disableTracing() now disables tracing (#6608) - #6643
Merged
delchev merged 1 commit intoAug 10, 2026
Merged
Conversation
…igible#6608) Both TracingFacade.disableTracing() and TaskStateService.disableTracing() set the DIRIGIBLE_TRACING_TASK_ENABLED flag to "true", so tracing could never be turned off once enabled. Set it to "false". Add enable->disable round-trip regression tests for both the service and the static facade, plus an @AfterEach that clears the global flag so it does not leak into other test classes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #6608.
disableTracing()contained a copy-paste error: it setDIRIGIBLE_TRACING_TASK_ENABLEDto"true"instead of"false", so once tracing was enabled it could never be turned off without a restart or manual config override.The same one-character bug existed in two places (the issue named only the first):
TracingFacade.disableTracing()— the static facade the engines (camel/bpm/jobs) consult viaisTracingEnabled().TaskStateService.disableTracing()— the Spring service method behind the tracing perspective/UI toggle.Both now set the flag to
"false".enableTracing()andisTracingEnabled()were already correct.Tests
Added enable→disable round-trip regression tests in
TaskStateServiceTestfor both the service and the static facade (they fail against the old"true"and pass now), plus an@AfterEachthat clears the globalDIRIGIBLE_TRACING_TASK_ENABLEDflag so the mutatedConfigurationdoes not leak into other test classes.mvn -pl components/core/core-tracing test -Dtest=TaskStateServiceTest→Tests run: 4, Failures: 0, Errors: 0.🤖 Generated with Claude Code