Propagate tenant config overrides into client-Java listener dispatch - #6649
Open
TIVMOF wants to merge 4 commits into
Open
Propagate tenant config overrides into client-Java listener dispatch#6649TIVMOF wants to merge 4 commits into
TIVMOF wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
{appUrl}notify token (#6642) resolves throughConfiguration, whose per-tenant overridelookup depends on a thread-scoped map. That map is only populated by
TenantConfigurationInitFilter, an HTTP-request-only filter. A generated notification fires from abackground
MessageHandler, dispatched byListenerClassConsumer— which re-establishes thetenant's identity (
tenantContext.execute(tenantId, ...)) but never loads that tenant's configoverrides. So a tenant that configured their own
DIRIGIBLE_APP_BASE_URLstill got the globaldefault in their notification emails — silently. The same gap affects any tenant-overridable config
value read from inside any client-Java listener, not just notifications.
Fix
ListenerClassConsumer.dispatch()now mirrorsTenantConfigurationInitFilter's exact pattern, justtriggered from message dispatch instead of an HTTP request: