Repository navigation
fix: keep the sub-task entries of stopped profiling tasks - #2279
Merged
cdietrich merged 1 commit intoNov 18, 2026
Merged
Conversation
ProfilingTask.stop() handed its own entries map to the new record and cleared that map right after, so every record returned by getRecords() had empty entries; only the console table, printed before the clear, showed the sub-tasks. Start a fresh map for the next run instead of clearing the one the record keeps. Fixes eclipse-langium#2277 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XkvVhAAk5NRLH75qMHMc3m
msujew
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2277
ProfilingTask.stop()handed its ownentriesmap to the new record and cleared that map right afteraddRecord. So every record returned bygetRecords()ended up with emptyentries; only the console table, which is printed before the clear, showed the sub-tasks.As discussed in #2277,
entriesis no longerreadonly, andstop()starts a fresh map for the next run instead of clearing the one the record keeps.Test: the new
profiler.test.tsruns a task twice and checks that each record keeps its own sub-task entries. It fails onmain(the first record's entries are empty) and passes with the fix.npm run build,npm run lintandnpm testpass.🤖 Generated with Claude Code
https://claude.ai/code/session_01XkvVhAAk5NRLH75qMHMc3m