Repository navigation
Conversation
shblue21
force-pushed
the
fix/indentation-eof-dedent
branch
from
November 22, 2026 13:57
ba9a420 to
ffc65ef
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the indented comment below the final milestone made VS Code report a parse error on the following blank line. Moving the comment to column 1 cleared the error. With this fix, the same file parses without errors with the comment still indented.
IndentationAwareLexerskips the emptyINDENT/DEDENTpair around the comment, then appends theDEDENTagain because it was the last token. In full mode, the lexer now appends the last token only if the loop hasn't already consumed it.The regression tests cover trailing spaces and comments, including CRLF. Partial tokenization keeps the last token because dropping it can prevent completion from suggesting
elseafter blank lines with different indentation.