test: cover more requirements#658
Open
a-zw wants to merge 1 commit into
Open
Conversation
a-zw
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
dcalavrezo-qorix and
nradakovic
as code owners
July 22, 2026 15:09
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
a-zw
force-pushed
the
test-existing-implementation
branch
from
July 22, 2026 15:24
c1a903a to
f3c3909
Compare
There was a problem hiding this comment.
Pull request overview
This PR expands the SCORE metamodel’s file-based RST test suite to cover additional safety, security, and standard-need type requirements, and wires these new test documents into Bazel test targets.
Changes:
- Add new RST-based requirements tests for security analysis types and multiple safety analysis constraints (types, mandatory/optional attributes, and
violateslinkage). - Add a new attributes test to validate
std_req/std_wpdirective support. - Introduce new Bazel
score_pytesttargets to run safety/security file-based tests.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/extensions/score_metamodel/tests/rst/security/test_security_types.rst | Adds RST-based tests for STRIDE threats and threat scenarios, including mandatory/optional attribute validation. |
| src/extensions/score_metamodel/tests/rst/safety/test_saf_violates.rst | Adds tests intended to validate violates link target-type constraints for SAF needs. |
| src/extensions/score_metamodel/tests/rst/safety/test_saf_types.rst | Adds tests ensuring SAF directive types exist and enforce mandatory attributes. |
| src/extensions/score_metamodel/tests/rst/safety/test_saf_optional_attrs.rst | Adds tests for optional SAF attributes (mitigation_issue, safety_relevant, root_cause). |
| src/extensions/score_metamodel/tests/rst/safety/test_saf_mandatory_attrs.rst | Adds tests for SAF mandatory attribute enforcement (including content requirements). |
| src/extensions/score_metamodel/tests/rst/attributes/test_std_types.rst | Adds tests verifying std_req and std_wp directives are supported. |
| src/extensions/score_metamodel/BUILD | Adds Bazel test targets for the new safety/security file-based RST test suites. |
Comment on lines
+142
to
+151
| data = [ | ||
| "tests/rst/safety/test_saf_types.rst", | ||
| "tests/rst/safety/test_saf_mandatory_attrs.rst", | ||
| "tests/rst/safety/test_saf_violates.rst", | ||
| "tests/rst/safety/test_saf_optional_attrs.rst", | ||
| ] + [ | ||
| "tests/__init__.py", | ||
| "tests/rst/conf.py", | ||
| "tests/rst/needs.json", | ||
| ], |
Comment on lines
+159
to
+163
| data = ["tests/rst/security/test_security_types.rst"] + [ | ||
| "tests/__init__.py", | ||
| "tests/rst/conf.py", | ||
| "tests/rst/needs.json", | ||
| ], |
Comment on lines
+29
to
+35
| .. feat_saf_dfa:: feat DFA violates feat arc sta | ||
| :id: feat_saf_dfa__viol__001 | ||
| :failure_id: df_001 | ||
| :failure_effect: comms loss | ||
| :sufficient: no | ||
| :status: valid | ||
| :violates: feat_arc_sta__001 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
🚨 Impact Analysis
✅ Checklist