test: add golden outputs for docs.bzl scenarios - #804
Conversation
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
Have to understand it a bit more, some questions etc.
But overall it makes sense to me in the most parts.
Once they are answered and I understand it a bit better I think we could look towards merging it.
|
|
||
| markers = [ | ||
| "bazel_cached: successful build-only test expected to reuse Bazel actions", | ||
| "bazel_slow: runtime execution or an uncached expected Bazel failure", |
There was a problem hiding this comment.
Do not quiet understand this marker?
There was a problem hiding this comment.
the idea was to run fast tests first and then the slow tests. however "fast" is not quite true. They are only fast because mostly they are cached. So I ended up with "cached" and "slow". Those are horrible categories, but so far I dont have a better approach.
There was a problem hiding this comment.
But they are only cached on second run right?
|
That last one is addressed in useblocks/sphinx-needs#1914 |
|
And that one in useblocks/sphinx-mounts#47 |
|
Documentation preview for this pull request is available at: |
|
|
||
| # TEMP UNTIL UPSTREAM FIX - BEGIN | ||
| # Bug ref: https://github.com/useblocks/sphinx-mounts/issues/47 | ||
| def configure_mounted_source_controls( |
There was a problem hiding this comment.
Should this be in this PR?
There was a problem hiding this comment.
we need that to generate identical html every time, as currently /home/<username>/.cache/... is added to the urls
| <dialog id="pst-secondary-sidebar-modal"></dialog> | ||
| <div id="pst-secondary-sidebar" class="bd-sidebar-secondary bd-toc"><div class="sidebar-secondary-items sidebar-secondary__inner"> | ||
|
|
||
|
|
||
| <div class="sidebar-secondary-item"> | ||
|
|
||
|
|
||
| <div class="tocsection editthispage"> | ||
| <a href="https://github.com/eclipse-score/docs-as-code/edit/main/src/tests/docs_bzl/scenarios/data_files_runfiles/docs/legacy_data_test/indexl/_bazel_alex/ec58ecca617edd0b2864120a40405cd7/execroot/_main/bazel-out/k8-fastbuild/bin/src/tests/docs_bzl/scenarios/data_files_runfiles/legacy_generated/index.rst"> | ||
| <i class="fa-solid fa-pencil"></i> | ||
|
|
||
|
|
||
|
|
||
| Edit on GitHub | ||
|
|
||
|
|
||
| </a> |
There was a problem hiding this comment.
Deleted on purpose? Why is the edit button missing in the new golden file?
There was a problem hiding this comment.
stuff that is mounted via data is not editable for now. this is not a regression as the link was broken up to now. better no link than broken link.
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
Talked about in many calls, seems good to me.
Size is this big cause of big golden files and scaffolding needed for testing.
2 participants
Why
The public
docs.bzlscenario tests kept many expected outputs encoded as Python assertions. That made the scenarios incomplete and difficult to understand or update.What
_expected/golden files and directories for the positive docs.bzl scenarios.