refactor: add central config class - #817
Merged
Merged
Conversation
AlexanderLanin
marked this pull request as ready for review
September 10, 2026 14:15
AlexanderLanin
requested review from
MaximilianSoerenPollak,
a-zw,
dcalavrezo-qorix and
nradakovic
as code owners
September 10, 2026 14:15
Contributor
|
Documentation preview for this pull request is available at: |
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
Contributor
There was a problem hiding this comment.
Just 1 question.
| ws_root = config.ws_root or Path() | ||
| # Docs source and output are resolved relative to the package where docs() | ||
| # was called; an empty PACKAGE_DIR denotes the workspace root. | ||
| package_dir = ws_root / (env.optional_path("PACKAGE_DIR") or Path()) |
Contributor
There was a problem hiding this comment.
So PACKAGE_DIR is not in the DocsCLIConfig ?
On purpose?
Contributor
There was a problem hiding this comment.
Same with output Dir in line 292
MaximilianSoerenPollak
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
almost no-op change, introducing a new class
differences: