added test cases for launch processes and conditional launching by Saumya-R · Pull Request #298 · eclipse-score/reference_integration

Saumya-R · 2026-07-16T17:21:06Z

This branch introduces lifecycle integration coverage for Launching Processes and Conditional Launching using a real launch_manager daemon setup, updates test infrastructure to reduce false negatives, and refreshes documentation/roadmap artifacts.

Requirement ID	Coverage in this PR	Verification level
feat_req__lifecycle__waitfor_support	Covered by daemon-backed conditional startup checks that wait for supervised process readiness in both lifecycle test classes.	Partially verifies (automated integration, daemon-backed)
feat_req__lifecycle__cond_process_start	Covered by conditional process startup assertions using real Launch Manager behavior (not stub-only checks).	Partially verifies (automated integration, daemon-backed)
feat_req__lifecycle__dependency_check	Covered by dependency-gated startup assertions and config dependency declaration checks for rust depending on cpp.	Partially verifies (automated integration, daemon-backed)
feat_req__lifecycle__process_ordering	Covered by launch ordering validation using process start ticks from /proc to assert dependency-respecting order.	Partially verifies (automated integration, daemon-backed)
feat_req__lifecycle__launch_support	Covered by startup launch validation that supervised apps are launched under Startup run target.	Partially verifies (automated integration, daemon-backed)
feat_req__lifecycle__monitor_abnormal_term	Covered by forced termination and restart/recovery behavior checks for supervised apps.	Partially verifies (automated integration, daemon-backed)
feat_req__lifecycle__liveliness_detection	Covered by manual watchdog flow that stalls process and validates watchdog/liveliness failure diagnostics.	Partially verifies (manual integration, daemon-backed)
feat_req__lifecycle__smart_watchdog_config	Covered by manual watchdog assertions for supervision timeout/failure transitions.	Partially verifies (manual integration, daemon-backed)

github-actions · 2026-07-16T17:47:54Z

The created documentation from the pull request is available at: docu-html

Copilot

Pull request overview

This PR adds a new Lifecycle “conditional launching” feature-integration test scenario and a Python FIT suite that runs it against both the Rust and C++ scenario runners. It also introduces a Rust “lifecycle-only” Bazel binary variant intended to avoid pulling in persistency-related dependencies for this specific suite, and updates test harness/configuration to support selective scenario builds.

Changes:

Added Lifecycle conditional-launching scenarios to the Rust and C++ FIT scenario trees.
Added a Python requirements-based FIT suite for conditional launching (parametrized for Rust/C++) plus a shared lifecycle base scenario fixture.
Added a Rust lifecycle-only Bazel scenario binary and updated FIT build selection/docs.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
pyproject.toml	Updates pytest configuration section to `tool.pytest.ini_options`.
feature_integration_tests/test_scenarios/rust/src/scenarios/mod.rs	Registers the new lifecycle scenario group in the Rust scenario tree.
feature_integration_tests/test_scenarios/rust/src/scenarios/lifecycle/mod.rs	Adds a lifecycle scenario group (Rust).
feature_integration_tests/test_scenarios/rust/src/scenarios/lifecycle/conditional_launching.rs	Implements the Rust conditional-launching scenario input validation/logging.
feature_integration_tests/test_scenarios/rust/src/main.rs	Adds `lifecycle_only` compilation mode and a reduced root group for lifecycle-only builds.
feature_integration_tests/test_scenarios/rust/BUILD	Adds `rust_lifecycle_test_scenarios` Bazel target using `--cfg=lifecycle_only`.
feature_integration_tests/test_scenarios/cpp/src/scenarios/mod.cpp	Registers a lifecycle scenario group (C++).
feature_integration_tests/test_scenarios/cpp/src/scenarios/lifecycle/conditional_launching.h	Declares the C++ conditional-launching scenario factory.
feature_integration_tests/test_scenarios/cpp/src/scenarios/lifecycle/conditional_launching.cpp	Implements the C++ conditional-launching scenario parsing/logging.
feature_integration_tests/test_cases/tests/lifecycle/test_conditional_launching.py	Adds Python FIT assertions for lifecycle conditional launching (Rust/C++).
feature_integration_tests/test_cases/lifecycle_scenario.py	Introduces a shared LifecycleScenario base class with a common `temp_dir` fixture.
feature_integration_tests/test_cases/conftest.py	Skips building unselected scenario variants based on the pytest mark expression.
feature_integration_tests/test_cases/BUILD	Adds `lifecycle_scenario.py` to FIT runfiles.
feature_integration_tests/README.md	Documents running lifecycle conditional-launching FITs and the lifecycle-only Rust target.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

added test case to reject unknown conditions fixed the readme added launch manager processes adding additional test cases for lifecycle

PiotrKorkus

also remove duplicated dependency/ordering tests across daemon files

PiotrKorkus · 2026-07-23T08:41:55Z

        "RUST_BACKTRACE": "1",
    },
    pytest_config = "//:pyproject.toml",
+    tags = ["exclusive"],


why is it needed?

lifecycle targets drive a shared launch_manager daemon and one of the rust or cpp times out when ran concurrently.

PiotrKorkus · 2026-07-23T08:42:40Z

+        "daemon_helpers.py",
+        "fit_scenario.py",
+        "lifecycle_scenario.py",
+        "persistency_scenario.py",


why is it here?

cleared the non-required.

PiotrKorkus · 2026-07-23T08:45:03Z

those bazel targets are messed up, create a separate targets for rust/cpp lifecycle, pers, orch etc. Group everything under test_suites for cpp and rust.
Just add one more level of test suites by promoting current fit_cpp and fit_rust into test suites

Cleared the mess.

PiotrKorkus · 2026-07-23T09:25:03Z

+@add_test_properties(
+    partially_verifies=[
+        "feat_req__lifecycle__total_wait_time_support",
+        "feat_req__lifecycle__polling_interval",
+        "feat_req__lifecycle__path_condition_check",
+        "feat_req__lifecycle__env_variable_cond_check",
+        "feat_req__lifecycle__dependency_check",
+    ],
+    test_type="requirements-based",
+    derivation_technique="requirements-analysis",
+)
+class TestConditionalLaunchingScenario(LifecycleScenario):


so those tests do not verify reqs, they verify the scenario

PiotrKorkus · 2026-07-23T09:28:13Z

+        if sched is None:
+            pytest.skip("Could not inspect scheduling metadata via chrt in this environment")


this is always skipped, test never contributes to verifify something

PiotrKorkus · 2026-07-23T09:31:08Z

+            f"(cpp_start={cpp_start}, rust_start={rust_start})"
+        )
+
+    def test_rust_never_runs_without_cpp_running(


but launch manager daemon fixutre always waits for both apps running, how does this test conrtibute to requirements verification? Its test harness check

PiotrKorkus · 2026-07-23T09:34:21Z

+        launch_manager_daemon: dict[str, Any],
+        version: str,
+    ) -> None:
+        """Verify launched process runs with configured effective uid/gid when runtime applies sandbox identity."""


what if gid is not applied? thats a pre condition from the outside, where is it set? Should the test be skipped if that was not prepared?

PiotrKorkus · 2026-07-23T09:37:46Z

+    def test_config_defines_startup_retry_policy(self, launch_manager_daemon: dict[str, Any], version: str) -> None:
+        """Verify lifecycle config defines configurable restart attempts on startup readiness failure."""
+        config_path = Path(__file__).resolve().parents[3] / "configs" / "lifecycle_daemon_config.json"
+        config = json.loads(config_path.read_text(encoding="utf-8"))
+
+        restart_cfg = config["defaults"]["deployment_config"]["ready_recovery_action"]["restart"]
+        attempts = restart_cfg.get("number_of_attempts")
+        assert isinstance(attempts, int), "Expected integer number_of_attempts in ready_recovery_action.restart"
+        assert attempts >= 0, "Expected non-negative number_of_attempts in startup retry policy"


thats reading json and asserting it, test makes no sense

deleted test_config_defines_startup_retry_policy — it only parsed and type-checked JSON, verifying nothing about runtime behavior. retries_configurable and monitor_abnormal_term are now both attributed to test_supervised_app_recovery, which is the one test that actually forces a failure and observes daemon-driven restart.

added test cases for conditional launching

78eff5e

Saumya-R requested a review from Copilot July 17, 2026 04:38

Copilot started reviewing on behalf of Saumya-R July 17, 2026 04:38 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

Saumya-R marked this pull request as ready for review July 17, 2026 05:25

Saumya-R requested review from AlexanderLanin, FScholPer, MaximilianSoerenPollak, PiotrKorkus, antonkri, dcalavrezo-qorix, lurtz, nradakovic, opajonk and pawelrutkaq as code owners July 17, 2026 05:25

Saumya-R marked this pull request as draft July 17, 2026 05:57

Saumya-R changed the title ~~added test cases for conditional launching~~ added test cases for launch processes and conditional launching Jul 21, 2026

Saumya-R marked this pull request as ready for review July 21, 2026 06:29

Copyright fixes

1c7d861

added test case to reject unknown conditions fixed the readme added launch manager processes adding additional test cases for lifecycle

Saumya-R force-pushed the saumya_lifecycle_integration_test_1 branch from 816b818 to 1c7d861 Compare July 22, 2026 06:28

PiotrKorkus requested changes Jul 23, 2026

View reviewed changes

removing the changes in pyproject and requirements txt

0816b16

		if sched is None:
		pytest.skip("Could not inspect scheduling metadata via chrt in this environment")

Uh oh!

Conversation

Saumya-R commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PiotrKorkus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Saumya-R commented Jul 16, 2026 •

edited

Loading