Marked txm_module_object_deallocate as deprecated#559
Open
fdesbiens wants to merge 1 commit into
Open
Conversation
Added a compile-time #pragma message warning to the module library source so that any module that includes or compiles this file receives an explicit deprecation notice at build time. Updated the internal documentation block in the manager-side implementation to explain that this function must not be called directly and that calling it on a live object causes a use-after-free. The Module Manager dispatch layer already releases pool memory automatically after a successful tx_*_delete() call. Module authors should remove any explicit call to txm_module_object_deallocate(). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
txm_module_object_deallocate()is deprecated. The Module Manager dispatch layer already releases pool memory automatically after every successfultx_*_delete()call from a module. There is no scenario in which a module should calltxm_module_object_deallocate()explicitly.Calling it on a live kernel object (before the corresponding
tx_*_delete()) is a use-after-free defect: pool memory is freed while the kernel still holds a reference to the object.Changes
common_modules/module_lib/src/txm_module_object_deallocate.c#pragma messagecompile-time warning so that any module that compiles this translation unit receives an explicit notice at build time.common_modules/module_manager/src/txm_module_manager_object_deallocate.cDESCRIPTIONblock to state that this function must not be called directly and that calling it on a live object causes a use-after-free.Credit
The use-after-free risk associated with calling
txm_module_object_deallocate()on a live kernel object was originally identified and reported by @Hack1ll. The report was reviewed and classified as misuse of a deprecated API rather than an exploitable vulnerability, but it prompted this documentation and code hardening effort.Companion
Docs update: eclipse-threadx/rtos-docs-asciidoc#32