Flagged txm_module_object_pointer_get as deprecated#562
Open
fdesbiens wants to merge 1 commit into
Open
Conversation
Added #pragma message compile-time warning to the module library source and updated the DESCRIPTION blocks in both the library and manager implementations. Reason: this wrapper passes UINT_MAX as the name-buffer length to the underlying extended search. The comparison loop can therefore read past the end of a short name buffer, which is undefined behaviour. Callers should use txm_module_object_pointer_get_extended() and supply the actual buffer length. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
txm_module_object_pointer_get()passesUINT_MAXas the name-buffer length to the underlying_extendedsearch. Ifnamepoints to a buffer shorter than the name being compared, the comparison loop reads past the end of the buffer (undefined behaviour). Callers must usetxm_module_object_pointer_get_extended()and supply the actual buffer length.Changes
common_modules/module_lib/src/txm_module_object_pointer_get.c: prominent deprecation comment block +#pragma messagecompile-time warning.common_modules/module_manager/src/txm_module_manager_object_pointer_get.c: updated DESCRIPTION block.Companion
Docs: eclipse-threadx/rtos-docs-asciidoc#33 (pending)