Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #86.
cdsapi.api.Client.download(result, "download.nc")currently splits the filename into characters, passing only"d"to the result downloader. A bytes path is split into integers, and apathlib.PathraisesTypeErrorbecause it is not iterable.Treat a single string, bytes or
os.PathLiketarget as one path. Keep iterable targets copied before consumption and preserve existing list/tuple and default-filename behavior. Add a method docstring and offline regression tests, including file writes through mocked HTTP responses.This change is scoped to
cdsapi.api.Client. Modern token-based clients delegate to the separateecmwf-datastores-clientimplementation, which is not modified here.Validation on Python 3.14:
pytest -q tests/test_download.py: 25 passed.git diff --check: passed.No real CDS credentials or data downloads were used.