Skip to content

Enable Node ACL based on ECF_PERMISSIONS ECFLOW-1960 #309

Draft
marcosbento wants to merge 2 commits into
developfrom
feature/node_acl
Draft

Enable Node ACL based on ECF_PERMISSIONS ECFLOW-1960 #309
marcosbento wants to merge 2 commits into
developfrom
feature/node_acl

Conversation

@marcosbento

@marcosbento marcosbento commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

Description

Enable Node ACL based on ECF_PERMISSION

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-309

@codecov-commenter

codecov-commenter commented Mar 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.35428% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.23%. Comparing base (cd0e323) to head (a740cb4).

Files with missing lines Patch % Lines
...ibs/server/src/ecflow/server/ServerEnvironment.cpp 51.11% 22 Missing ⚠️
libs/server/src/ecflow/server/HttpServer.cpp 23.80% 16 Missing ⚠️
libs/node/src/ecflow/node/permissions/Allowed.cpp 50.00% 7 Missing ⚠️
libs/node/src/ecflow/node/Alias.cpp 40.00% 3 Missing ⚠️
libs/node/src/ecflow/node/formatter/DefsWriter.hpp 88.46% 3 Missing ⚠️
libs/base/src/ecflow/base/stc/SSyncCmd.cpp 88.88% 2 Missing ⚠️
.../server/src/ecflow/server/AuthorisationService.cpp 90.00% 2 Missing ⚠️
libs/base/src/ecflow/base/cts/user/CSyncCmd.cpp 75.00% 1 Missing ⚠️
libs/node/src/ecflow/node/AuthorisationContext.hpp 90.00% 1 Missing ⚠️
libs/node/src/ecflow/node/Family.cpp 83.33% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #309      +/-   ##
===========================================
+ Coverage    52.08%   52.23%   +0.15%     
===========================================
  Files         1247     1254       +7     
  Lines       101710   102120     +410     
  Branches     15136    15195      +59     
===========================================
+ Hits         52971    53346     +375     
- Misses       48739    48774      +35     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcosbento
marcosbento force-pushed the feature/node_acl branch 5 times, most recently from fde7c0b to df129dd Compare April 17, 2026 07:35
@marcosbento
marcosbento force-pushed the develop branch 2 times, most recently from e4e5beb to 02a695f Compare April 20, 2026 12:54
@marcosbento
marcosbento force-pushed the feature/node_acl branch 4 times, most recently from 86cd87d to aea1484 Compare April 29, 2026 07:19
@marcosbento
marcosbento force-pushed the feature/node_acl branch 2 times, most recently from 5d06db4 to edcaf92 Compare May 20, 2026 12:35
@marcosbento
marcosbento force-pushed the feature/node_acl branch 3 times, most recently from a6b5981 to ec2b2b2 Compare June 24, 2026 16:24
@marcosbento
marcosbento force-pushed the feature/node_acl branch 6 times, most recently from 30b6e51 to af21159 Compare July 15, 2026 15:14
Until we find another solution, and we have to find a proper solution,
bypassing the cache ensures that the definition is filtered through
on request basis (i.e. based on the user performing the request).

Solutions might be to have a cache per user!?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants