Refactor Python tests to make consistent use of pytest ECFLOW-2110#381
Open
marcosbento wants to merge 15 commits into
Open
Refactor Python tests to make consistent use of pytest ECFLOW-2110#381marcosbento wants to merge 15 commits into
marcosbento wants to merge 15 commits into
Conversation
marcosbento
force-pushed
the
task/use_pytest
branch
from
July 9, 2026 07:27
dc6bd8b to
06ad79a
Compare
marcosbento
changed the title
marcosbento
force-pushed
the
task/use_pytest
branch
2 times, most recently
from
July 10, 2026 08:58
ad40acd to
11b0136
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #381 +/- ##
========================================
Coverage 52.08% 52.08%
========================================
Files 1247 1247
Lines 101710 101710
Branches 15136 15136
========================================
+ Hits 52971 52975 +4
+ Misses 48739 48735 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
marcosbento
force-pushed
the
task/use_pytest
branch
5 times, most recently
from
July 16, 2026 18:28
8b169e2 to
c057178
Compare
Re ECFLOW-2110
Re ECFLOW-2110
Re ECFLOW-2110
Re ECFLOW-2110
Re ECFLOW-2110
Re ECFLOW-2110
At this point, there is a single entry point that is pytest collected, but then the "tests" are executed by sequentially calling the test functions as before. Re ECFLOW-2110
This class simply delegates to the preexisting _test_*. Re ECFLOW-2110
This effectively inlines the _test_* functions into the test, and thus concludes the migration of the integration tests to pytest. Re ECFLOW-2110
Re ECFLOW-2110
This is a small improvement, detected during code review. Re ECFLOW-2110
This is a small improvement, detected during code review. Re ECFLOW-2110
This covers a small set of improvements, detected during code review. Re ECFLOW-2110
On some HPC toolchains, a third-party Python package imported before ecflow (for example numpy) resolves and loads the platform default libstdc++ first. Since ELF soname resolution is process-wide and first-one-wins, this can leave ecflow.so unable to satisfy the GLIBCXX symbol version it was actually built against, when the build toolchain differs from the platform default. Add ECFLOW_PYEXT_TEST_LD_LIBRARY_PATH, a configure-time cache variable that prepends a given runtime library directory to LD_LIBRARY_PATH for the py3_u_* and py3_s_* tests, so the correct libstdc++.so.6 is resolved regardless of which component asks for it first. Left empty by default, leaving unaffected platforms untouched. Wire the new flag into the gnu-15.2.0 and gnu-14.2.0 HPC CI jobs in .github/ci-hpc-config.yml, pointing at each toolchain's libstdc++ directory, so the affected python tests actually pass in CI.
marcosbento
force-pushed
the
task/use_pytest
branch
from
July 17, 2026 15:14
c057178 to
28ab0be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As per PR title.
Contributor Declaration
By opening this pull request, I affirm the following:
🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-381