Repository navigation
IPFS uploads are orphaned when the proof commit fails after upload; no content-address dedup #69
Description
Why this matters now: Wasted storage/cost and a growing set of unreferenced CIDs; also a minor correctness gap (duplicate photos re-uploaded).
Problem / What: In submitProof (proofController.ts:111-145), files are hashed, metadata-extracted, and uploaded to IPFS before the DB transaction that creates the proof. If the commit (or the subsequent enqueueVerification) fails, the CIDs already in IPFS are never cleaned up. There is also no reuse of an already-stored CID for identical content.
Key Challenges: Defining an orphan-reclamation strategy (track uploaded CIDs per request, roll back on failure, or a periodic GC job), and optionally de-duplicating via the existing sha256 uniqueness.
Acceptance Criteria:
- A failed proof submission does not leave referenced-but-uncommitted CIDs permanently orphaned (test injects a commit failure and asserts cleanup).
- Identical content reuses the existing CID where desired.
Relevant files/functions: src/controllers/proofController.ts:100-236, src/services/ipfsService.ts:4-34, src/middleware/upload.ts:11-30.
Out of scope: IPFS pinning policy.
Labels: advanced, reliability, bug
Activity
telemarkdigital-publisher commentedon Aug 21, 2026
I can take this. Plan: (1) trace the submitProof upload/transaction/enqueue path, (2) add explicit cleanup or durable orphan tracking for CIDs uploaded before a failed commit/enqueue, (3) add sha256/CID reuse for identical content where the existing model supports it, and (4) cover the failure and dedup paths with focused tests. Expected verification: run the repo's backend test command, any lint/typecheck script present, and a targeted proof-controller/IPFS test if available before opening the PR.
Christopherdominic commentedon Aug 21, 2026
Can I work on this issue I can raise a pr within 2 days
grantfox-oss commentedon Aug 21, 2026
🦊 GrantFox — @Christopherdominic has been assigned to this issue as part of the Third Campaign campaign!
Next steps:
Closes #69)Good luck! Track your progress on GrantFox.
fix(proofs): reclaim orphaned IPFS uploads and dedup identical photo …
grantfox-oss commentedon Aug 24, 2026
🎉 This issue has been marked as completed on GrantFox as part of the Third Campaign campaign!
@Christopherdominic's PR #98 was approved and merged by @cybermax4200.
🏆 @Christopherdominic: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (958 total points). Track your full progress on GrantFox.
👏 Great work, @Christopherdominic! Keep contributing to ecotask-network.