fix(logging): configure log destination and file names - #421
Open
crazy0104 wants to merge 1 commit into
Open
Conversation
- select destination folders instead of existing files - support field-code naming with timestamped previews - preserve legacy paths and validate Windows-safe names - add log naming unit tests
crazy0104
marked this pull request as ready for review
August 1, 2026 18:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{LocalTime}and a live filename previewWhy
The previous browser used an open-file dialog, so users had to select an existing file even though logging creates a new file. It also did not provide a clear way to configure timestamped log names independently from the destination directory.
This change lets users select where logs should be saved and define how new log files are named before recording starts.
Validation
npx vitest --config vitest.config.ts run test/transport/logFile.test.ts— 5 tests passednpm run typecheck