Skip to content

fix: inconsistent loading of discussion thread response#59

Open
naincy128 wants to merge 6 commits into
release-ulmofrom
LP-529
Open

fix: inconsistent loading of discussion thread response#59
naincy128 wants to merge 6 commits into
release-ulmofrom
LP-529

Conversation

@naincy128

@naincy128 naincy128 commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Description

Optimizes discussion comment loading by replacing in-memory sorting/pagination with DB-level operations and removing dead code that fired unnecessary queries per comment.

Root Cause

Comment.get_list() loaded all matching comments into memory using Python sorted(), then sliced — with no select_related, causing ~4 FK queries per comment in to_dict().

Additionally, CommentSerializer.to_representation() re-fetched the full thread and comment from the DB for every comment (~15 queries each) to perform an endorsement check that never executed — the condition "endorsement" not in comment_from_db was always False since to_dict() always includes the key.

For 10 comments, this resulted in ~258 queries and ~30s load times.

Changes

  • Replaced Python sorted() with DB-level order_by() using F('sort_key').asc(nulls_last=True)
  • Replaced Python slicing with QuerySet slicing (DB LIMIT/OFFSET)
  • Added select_related('author', 'parent', 'comment_thread', 'deleted_by') to eliminate FK N+1
  • Removed dead get_thread() and get_comment() calls from to_representation()

Impact

~258 queries → ~59 queries (77% reduction), load time ~30s → ~8-10s

Linked PRs

edx-platform
frontend-app-discussions

Ticket

LP-529

@naincy128
naincy128 marked this pull request as ready for review June 30, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant