fix: inconsistent loading of discussion thread response#59
Open
naincy128 wants to merge 6 commits into
Open
Conversation
naincy128
marked this pull request as ready for review
June 30, 2026 08:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimizes discussion comment loading by replacing in-memory sorting/pagination with DB-level operations and removing dead code that fired unnecessary queries per comment.
Root Cause
Comment.get_list() loaded all matching comments into memory using Python sorted(), then sliced — with no select_related, causing ~4 FK queries per comment in to_dict().
Additionally, CommentSerializer.to_representation() re-fetched the full thread and comment from the DB for every comment (~15 queries each) to perform an endorsement check that never executed — the condition "endorsement" not in comment_from_db was always False since to_dict() always includes the key.
For 10 comments, this resulted in ~258 queries and ~30s load times.
Changes
Impact
~258 queries → ~59 queries (77% reduction), load time ~30s → ~8-10s
Linked PRs
edx-platform
frontend-app-discussions
Ticket
LP-529