Skip to content

Move Effect diagnostics to Oxlint - #851

Merged
patroza merged 2 commits into
mainfrom
t3code/effect-oxlint
Aug 5, 2026
Merged

Move Effect diagnostics to Oxlint#851
patroza merged 2 commits into
mainfrom
t3code/effect-oxlint

Conversation

@omegent-app

@omegent-app omegent-app Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Why

Effect diagnostics currently run through the TypeScript language-service patch, while Oxlint is already the repository lint engine. This makes diagnostics differ between editor/compiler and lint workflows.

What

Enable the @effect/tsgo Oxlint integration with type-aware linting, migrate the configured Effect diagnostic severities to Oxlint rules, and disable diagnostics in the language-service plugin. Keep the existing TypeScript 6 / tsgo compiler path unchanged.

The Oxlint upgrade also applies safe type-aware fixes for assertions that the compiler can prove unnecessary.

How

Patch only Oxlint during prepare with effect-tsgo patch --no-typescript --oxlint. The language-service plugin remains installed but runs with diagnostics: false.

Pragmatic fit: preserve the customized compiler setup and move diagnostics only. Greenfield ideal: adopt @effect/tsgo for both compiler and lint once the remaining compiler customization can be retired; this PR is the reversible diagnostics-first step.

Remarks

Internal tooling only; no flow, machine, or browser behavior changes.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
@omegent-app
omegent-app Bot marked this pull request as ready for review August 5, 2026 06:17
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
@pkg-pr-new

pkg-pr-new Bot commented Aug 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

@effect-app/cli

npm i https://pkg.pr.new/effect-app/libs/@effect-app/cli@851

effect-app

npm i https://pkg.pr.new/effect-app/libs/effect-app@851

@effect-app/eslint-codegen-model

npm i https://pkg.pr.new/effect-app/libs/@effect-app/eslint-codegen-model@851

@effect-app/eslint-shared-config

npm i https://pkg.pr.new/effect-app/libs/@effect-app/eslint-shared-config@851

@effect-app/infra

npm i https://pkg.pr.new/effect-app/libs/@effect-app/infra@851

@effect-app/vue

npm i https://pkg.pr.new/effect-app/libs/@effect-app/vue@851

@effect-app/vue-components

npm i https://pkg.pr.new/effect-app/libs/@effect-app/vue-components@851

commit: ac64f29

@patroza
patroza merged commit c63c0af into main Aug 5, 2026
6 checks passed
@patroza
patroza deleted the t3code/effect-oxlint branch August 5, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant