Add arena-backed hash map and docs#4
Merged
Merged
Conversation
Comment on lines
+440
to
+443
| u64 target_capacity = normalize_capacity(requested_capacity); | ||
| if (io_capacity >= target_capacity) { | ||
| return HashMapR<bool>::ok(false); | ||
| } |
Comment on lines
+499
to
+503
| u64 target_capacity = normalize_capacity(requested_capacity); | ||
|
|
||
| if (io_capacity >= target_capacity) { | ||
| return HashMapR<bool>::ok(false); | ||
| } |
Comment on lines
+445
to
+454
| u64 snapshot = arena.offset; | ||
|
|
||
| K* new_keys = arena.alloc_array<K>(target_capacity); | ||
| V* new_values = arena.alloc_array<V>(target_capacity); | ||
| u64* new_hashes = arena.alloc_array<u64>(target_capacity); | ||
| u8* new_ctrl = arena.alloc_array<u8>(target_capacity); | ||
|
|
||
| if (!new_keys || !new_ctrl || !new_values || !new_hashes) { | ||
| arena.offset = snapshot; | ||
| return HashMapR<bool>::err(HashMapE::OutOfMemory); |
Comment on lines
+505
to
+514
| u64 snapshot = arena.offset; | ||
|
|
||
| K* new_keys = arena.alloc_array<K>(target_capacity); | ||
| u64* new_hashes = arena.alloc_array<u64>(target_capacity); | ||
| u8* new_ctrl = arena.alloc_array<u8>(target_capacity); | ||
|
|
||
| if (!new_keys || !new_ctrl || !new_hashes) { | ||
| arena.offset = snapshot; | ||
| return HashMapR<bool>::err(HashMapE::OutOfMemory); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core_hashmodule with hash traits for integer keys andStr8core_hash_mapmodule using Robin Hood open addressing with cached per-slot hashesHashMap<K, void>andHashSet<K>Str8::match(...)andStr8::hash_fnv1a()const so hash traits can use them directlyReview and Audit
Validation
makemake docsScope Notes