Repository navigation
test: give the host-backed tests upstream's 30 s timeout - #2
Merged
Merged
Conversation
The first CI run on main timed out one test on EmDash 0.39.0 and a dozen in the informational job. They run the plugin inside workerd through the test host; the heaviest take about 2.5 s on a fast laptop, and a shared CI runner pushed them past vitest's 5 s default. The same commit's tree had passed on the pull request. Upstream's plugin-test suite uses 30 s for the same reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first CI run on
mainafter #1 failed: one test timed out on EmDash 0.39.0 in the gating job, and about a dozen in the informational job. The same tree had passed on the pull request.The tests are slow on shared runners, not hung. They run the plugin inside workerd through the test host; locally the heaviest take about 2.5 s and 37 take over a second, so a busier runner crosses vitest's 5 s default. This sets
testTimeoutandhookTimeoutto 30 s, the values upstream's ownplugin-testsuite uses.