Skip to content

ci: plan registry releases from the inputs, not from github.event_name - #20

Merged
danielmlr merged 1 commit into
mainfrom
fix/registry-plan-trigger
Sep 28, 2026
Merged

danielmlr merged 1 commit into
mainfrom
fix/registry-plan-trigger

Conversation

@danielmlr

Copy link
Copy Markdown
Member

The first registry run after the 0.2.1 npm publish (run 36407668327) failed without publishing anything to the registry. npm was not affected: 0.2.1 is on npm with provenance.

Cause

emdash-release.yml picks its plan step with github.event_name == 'workflow_call' and github.event_name == 'workflow_dispatch'. In a called workflow, github.event_name is the caller's event: release.yml runs on push, so the value was push. Neither plan step ran, selectors stayed empty, '' != '[]' let the build job through, and fromJSON('') could not produce its matrix. The run failed there, and the publish job was skipped.

The two conditions come unchanged from emdash-plugin release setup (plugin-cli 0.12.0). The generator on upstream main still writes them, so any repository with the Changesets trigger hits this.

Change

Each plan step now checks whether its own input is set: inputs.published-packages for the Changesets call, inputs.package for a manual dispatch. The inputs context carries the values of whichever trigger started the run.

Verified

  • actionlint 1.7.7 passes on emdash-release.yml and release.yml. It passed on the old conditions as well: this is a runtime value, not a syntax error.
  • The log of the plan job in the failed run shows published-packages: [{"name":"@eisbachcode/emdash-plugin-analytics","version":"0.2.1"}] as the input, and neither plan step executed.
  • Not run end to end: that needs the next npm publish.

@changeset-bot

changeset-bot Bot commented Sep 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d1cf18c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@danielmlr
danielmlr merged commit dd7b9db into main Sep 28, 2026
2 checks passed
@danielmlr
danielmlr deleted the fix/registry-plan-trigger branch September 28, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant