Repository navigation
ci: plan registry releases from the inputs, not from github.event_name - #20
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first registry run after the 0.2.1 npm publish (run 36407668327) failed without publishing anything to the registry. npm was not affected: 0.2.1 is on npm with provenance.
Cause
emdash-release.ymlpicks its plan step withgithub.event_name == 'workflow_call'andgithub.event_name == 'workflow_dispatch'. In a called workflow,github.event_nameis the caller's event:release.ymlruns onpush, so the value waspush. Neither plan step ran,selectorsstayed empty,'' != '[]'let the build job through, andfromJSON('')could not produce its matrix. The run failed there, and the publish job was skipped.The two conditions come unchanged from
emdash-plugin release setup(plugin-cli 0.12.0). The generator on upstream main still writes them, so any repository with the Changesets trigger hits this.Change
Each plan step now checks whether its own input is set:
inputs.published-packagesfor the Changesets call,inputs.packagefor a manual dispatch. Theinputscontext carries the values of whichever trigger started the run.Verified
emdash-release.ymlandrelease.yml. It passed on the old conditions as well: this is a runtime value, not a syntax error.published-packages: [{"name":"@eisbachcode/emdash-plugin-analytics","version":"0.2.1"}]as the input, and neither plan step executed.