Repository navigation
docs(analytics): screenshots, URL patterns and the restart the setup check needs - #4
Merged
Merged
Conversation
…check needs The README gets five screenshots from demo data on a site made from EmDash's blog template (widget, Analytics page, setup check, per-entry page, editor panel); the manifest lists them for the registry listing. Taking them found two things the setup check now says: - Collections from the blog template have no URL pattern, so no entry has a public URL and nothing can be matched. The index sentence names the URL Pattern field under Content Types and Rebuild index, and the README lists URL patterns under what the plugin needs. - EmDash reads the site URL into a plugin's context when the server starts. A server that was already running when the setup wizard stored it keeps reporting none until it restarts, which the site URL sentence now says.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots for the README and the registry listing, and two setup-check sentences corrected by what taking them found.
Screenshots
Five shots at 2x from demo data on a throwaway site made with
create-emdash(blog template, EmDash 0.39.1): the dashboard widget, the Analytics page, the setup check, Analytics per entry and the editor panel. They are referenced from the README with absoluteraw.githubusercontent.comURLs, so they also render on npm, and listed underrelease.artifacts.screenshotsin the manifest (each under 1 MiB). The npm tarball does not include them.What the demo site showed
getPublicUrl()is null, so the index matches nothing. The setup check said so, but only "check that the collections have URL patterns". It now names the URL Pattern field under Content Types and Rebuild index, and the README lists URL patterns under "What you need". After setting/posts/{slug}and/pages/{slug}and rebuilding, all 8 entries matched.emdash:site_urlwas stored; after a restart it was there. The sentence now says a running server picks it up after a restart.Verified
emdash-plugin validatewith the artifacts.