Repository navigation
Move TextureLayerCanvasView - #252
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The active test plan still references the removed package test target, which can break the CI test lane.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Moves TextureLayerCanvasView from a standalone Swift package into the main application target.
Changes:
- Migrates canvas implementation and utilities into the app.
- Updates imports and test target membership.
- Removes the obsolete package configuration and project dependency.
| File | Description |
|---|---|
TextureLayerCanvasView/Sources/TextureLayerCanvasView/Utils/Logger.swift |
Removes package logger. |
TextureLayerCanvasView/Sources/TextureLayerCanvasView/Extensions/NSErrorExtensions.swift |
Removes package error extension. |
TextureLayerCanvasView/Package.swift |
Removes package manifest. |
TextureLayerCanvasView/IDETemplateMacros.plist |
Removes package template settings. |
HandDrawingSwiftMetalTests/Views/TextureLayerCanvasView/TextureLayerSelectionTests.swift |
Tests the app module instead. |
HandDrawingSwiftMetalTests/Models/Undo/UndoableTextureLayersStateTests.swift |
Removes obsolete package import. |
HandDrawingSwiftMetal/Views/TextureLayerCanvasView/TextureLayerCanvasViewModel.swift |
Adds canvas view model to app. |
HandDrawingSwiftMetal/Views/TextureLayerCanvasView/TextureLayerCanvasViewDependencies.swift |
Adds canvas dependencies. |
HandDrawingSwiftMetal/Views/TextureLayerCanvasView/TextureLayerCanvasView.swift |
Adds the canvas view. |
HandDrawingSwiftMetal/Views/TextureLayerCanvasView/TextureLayerCanvasUpdating.swift |
Adds canvas update protocol. |
HandDrawingSwiftMetal/Views/TextureLayerCanvasView/TextureLayerCanvasRenderer.swift |
Adds layer rendering logic. |
HandDrawingSwiftMetal/Views/TextureLayerCanvasView/Layers/TextureLayerSelection.swift |
Adds layer selection partitioning. |
HandDrawingSwiftMetal/Views/TextureLayerCanvasView/Layers/TextureLayers.swift |
Adds layer snapshots container. |
HandDrawingSwiftMetal/Views/TextureLayerCanvasView/Layers/TextureLayerCanvasProtocol.swift |
Adds canvas layer interfaces. |
HandDrawingSwiftMetal/Views/TextureLayerCanvasView/Layers/TextureLayer.swift |
Updates moved file header. |
HandDrawingSwiftMetal/Utils/DrawingDebouncer.swift |
Updates moved file header. |
HandDrawingSwiftMetal/Utils/Debouncer.swift |
Updates moved file header. |
HandDrawingSwiftMetal/Models/Undo/UndoCoordinator.swift |
Removes obsolete import. |
HandDrawingSwiftMetal/Models/TextureLayers/TextureLayersStateProtocol.swift |
Removes obsolete import. |
HandDrawingSwiftMetal/Models/TextureLayers/TextureLayersState.swift |
Removes obsolete import. |
HandDrawingSwiftMetal/HandDrawingViewModel.swift |
Removes obsolete import. |
HandDrawingSwiftMetal/HandDrawingViewController.swift |
Removes obsolete import. |
HandDrawingSwiftMetal/Extensions/MTLCommandBuffer.swift |
Updates moved file header. |
HandDrawingSwiftMetal/Extensions/Collection.swift |
Updates moved file header. |
HandDrawingSwiftMetal.xcodeproj/project.pbxproj |
Reconfigures sources, tests, and dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.