Repository navigation
Add VerticalDiameterSlider - #254
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Compact-height layout and accessibility issues remain unresolved.
2 open findings
What changed in this PR
Replaces UIKit diameter sliders with shared SwiftUI controls bound directly to the drawing-tool model.
Changes:
- Adds vertical sliders with numeric values and steppers for brush and eraser diameters.
- Updates hosting, outlets, layout, and project registration.
| File | Description |
|---|---|
| HandDrawingSwiftMetal/Views/Components/VerticalDiameterSlider/VerticalDiameterSlider.swift | Adds the reusable diameter control. |
| HandDrawingSwiftMetal/Views/Components/VerticalDiameterSlider/EraserVerticalDiameterSlider.swift | Adds the eraser wrapper. |
| HandDrawingSwiftMetal/Views/Components/VerticalDiameterSlider/BrushVerticalDiameterSlider.swift | Adds the brush wrapper. |
| HandDrawingSwiftMetal/Models/DrawingTools/DrawingTool.swift | Simplifies header comments only. |
| HandDrawingSwiftMetal/HandDrawingViewController.swift | Hosts SwiftUI controls with model bindings. |
| HandDrawingSwiftMetal/HandDrawingContentView.xib | Replaces sliders with hosting containers. |
| HandDrawingSwiftMetal/HandDrawingContentView.swift | Updates outlets and removes legacy slider callbacks. |
| HandDrawingSwiftMetal.xcodeproj/project.pbxproj | Registers the new Swift files. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.