Skip to content

0.7.1: Pin x264 source for repeatable media builds #118

Closed

Description

@andersalm

Owner: Anders (@andersalm). Release: 0.7.1.

Problem

PR #115 Linux x86-64 source-home run stopped with Source checksum mismatch: x264-b35605ace3ddf7c1a5d67a2eb553f034aef41d55.tar.bz2. The build downloads a generated archive from an external server.

Fix

Fetch the pinned x264 Git commit, verify its tree, and create the archive locally. Keep the existing SHA-256 check before extraction or compilation. Preserve the source archive, licenses and build provenance in the media-tools package.

Done means

Release acceptance: Each exposed feature works clearly from start to end, including recovery. Keep unfinished or confusing features hidden until their complete journey passes. Hiding a feature does not complete its task; source checks alone do not establish installed acceptance.

  • The build uses the exact commit and verified tree, without the generated-archive endpoint.
  • Repeated clean fetches produce the existing pinned archive SHA-256.
  • Tests reject a wrong tree, changed source bytes and corrupt cached source.
  • Local source and packaging checks pass; CI verifies the native source-home jobs.

Part of #93.

Draft fix: #119 (f7e9446d). All 49 local source, cache and packaging tests passed. Two clean upstream fetches matched the existing SHA-256. Native source-home CI is running.

Activity

  1. added this to the 0.7.1 milestone on Sep 29, 2026
  2. self-assigned this
    on Sep 29, 2026
  3. andersalm commented on Sep 29, 2026

    @andersalm
    ContributorAuthor

    Independent review of f7e9446 found no actionable correctness, regression or security issue. The fetch binds the exact commit and tree, then checks the existing archive SHA-256 before extraction. Review also checked cleanup, modes and licence handling. Local checks already recorded remain valid. CI run 36594454827 is still completing the platform builds.

  4. andersalm commented on Sep 29, 2026

    @andersalm
    ContributorAuthor

    PR #119 merged normally into feat/0.7.1-models as e80269c. Reviewed source: f7e9446. All eight required checks passed in run 36594454827, including both Linux source-home builds and macOS. The exact commit/tree fetch preserves the approved x264 archive SHA-256. Local tests and independent review are recorded above. This closes the source-build pinning task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions