Skip to content

Chat and app web links require Home confirmation of the exact destination (0.8.0 F1 gate) #430

Open

Description

@andersalm

Home shows the exact HTTP(S) destination requested by Chat or an app. The person confirms or cancels in Home-owned UI, and Runtime permits only the confirmed destination to open in the user’s browser with no opener.

Anders confirmed on 17 October 2026: "Keep required: implement and test the approved link flow." This is a 0.8.0 release requirement. OMP owns source implementation; Codex provides independent review and assigned isolated acceptance; Sasha owns the required confirmation-UI acceptance.

That same sandbox closes the exfiltration path of the chat isolation audit's F1. A compromised app cannot open https://evil/?data by itself. The CSP header on app documents still lists allow-popups (browser_capsules.rs), but inside Home the iframe sandbox wins.

Not the fix: the first broker (fix/080-app-popups, held on hold/train-rc8-popups-da5e067f0) opened whatever URL an app sent during any click. That is weaker than today's behaviour (independent review hold, #93 comment 6229810265).

Done means:

  • An app or Chat asks Home to open a link through a typed Runtime-mediated request that names the exact URL.
  • Home shows that exact destination in Home-owned UI, and the person confirms or cancels. Only the confirmed URL opens, in the user's browser, with no opener.
  • Tests: refusal without confirmation; the URL cannot be swapped between request and confirmation; non-http(s) schemes are refused; the app CSP drops allow-popups; the "links do not open" known issue is removed from the notes.
  • Sasha approves the confirmation UI. Independent review passes. A Mac smoke shows a Chat link opening after confirmation.

Shipped in alpha.24 (33cc91dfe, 4320055b8, 3835d7efd, d42614f89); the [0.8.0] notes say links open after Open link. Candidate: see #93. Remaining: installed Mac Community and DM link with Cancel/Open and return to the same Home on alpha.25; Sasha's UI approval on real phones.

Activity

  1. modified the milestones: After 0.8.0, 0.8.0 on Oct 17, 2026
  2. changed the title [-]Chat and app web links open only after Home shows and the person confirms the exact destination (F1 follow-up)[/-] [+]Chat and app web links require Home confirmation of the exact destination (0.8.0 F1 gate)[/+] on Oct 17, 2026
  3. andersalm commented on Oct 17, 2026

    @andersalm
    ContributorAuthor

    Implementation, unpushed: branch fix/080-link-confirm, 5 commits on 6ee5fa7f2:

    • 993b64a06: the Runtime route POST /api/apps/home/external-link.
    • 23753cc20: the Home confirmation sheet and smokes.
    • 5df8405a7: the Chat sender and rebuilt wasm.
    • 6ada9159b: the app CSP drops allow-popups; the Browser and UniSat extras are removed (neither uses popups).
    • fdcb895ef: release notes.

    Author checks: fmt and clippy clean; Rust route and sandbox tests pass; Chat source and artifacts match; test-source-gate.sh product-ui passes; the phone smoke passes on WebKit and Chromium. In every profile the sheet names the app, focus starts on Cancel, buttons are at least 44 px, opener === null, and the destination gets exactly one request, after Open.

    Not yet done: independent reviews (Codex and Claude, running now), integration into the train, Sasha's UI approval (screenshots to follow here) and the installed Mac smoke.

    For the installed Mac smoke: in headless Chromium phone emulation, opening and closing any new tab, even about:blank, stopped later app windows from opening in the Home GUI. Check whether this also happens on a real Mac.

    Follow-up: Documents preview links, #436.

  4. andersalm commented on Oct 17, 2026

    @andersalm
    ContributorAuthor

    Screenshots of the confirmation sheet from the phone layout smoke (WebKit and Chromium; phone portrait, phone landscape, tablet) are in ~/.local/share/elastos-ops/proofs/430-link-sheet/ on Anders's Mac, for upload here for @SashaMIT's UI approval. The sheet shows: the label "WEB LINK"; the title "Open this link?"; " wants to open this address in your browser."; the host in large text; the full URL in a scrollable monospace box; then Open link and Cancel, with focus on Cancel.

  5. andersalm commented on Oct 17, 2026

    @andersalm
    ContributorAuthor

    Independent evidence audit at unpublished fdcb895/treecd12a6efd31fc5e572c254647ca536ed3c8554c9: both author JSON reports cover portrait, landscape and tablet. Six inspected link probes show44px controls, Cancel focus, preserved destination, synthetic-click refusal, one destination request, null opener and empty referrer. Private receipt SHA-256:6f35562499a5eb619e204858762fceae1efa2396a74b8ab6d6e63eb4e4b6a6ed. Reports lack commit/exit metadata; this admits observations under the author record, not an independent full-smoke exit or installed result.
    Existing phone failure gates remain, but the popup probe uses a fresh Home/context after the main app-layout context closes (home-phone-layout-smoke.mjs:2025). Runtime validation is stubbed there; configured Chat ends after its bridge request. These checks leave the full installed chain and later app use in the same Home unproven. The reported about:blank control has no established cause; context separation does not prove recovery.
    Installed Mac acceptance must bind Runtime/capsule hashes, exercise real Chat→Runtime→Home→browser Cancel/Confirm, close the destination and return to the same Home without reload, then open a previously unopened app, reopen Chat, and exercise affected Browser/Wallet journeys. Sasha UI approval remains required. Root launched no duplicate tests or product sessions. Sasha needs viewable screenshots attached to this issue; local captures alone leave that handoff pending.

  6. andersalm commented on Oct 17, 2026

    @andersalm
    ContributorAuthor

    The owner-commissioned Codex review passed fdcb895, with an in-memory reproduction of a Home CLI link prompt surviving CLI reload. The accepted request-retirement lifecycle includes reload; this case remains open before the final freeze. The destination stays immutable and Open still requires a trusted Home click, so this establishes a lifecycle gap rather than an unapproved navigation.
    At this snapshot, app-ready retires app requests, while shell-ready settles the CLI frame without retiring its request; externalLinkSenderIsLive checks the active CLI token. Retire the CLI request on reload and add a focused regression for both an already-shown prompt and an in-flight response arriving after reload.
    Owner16:18 reports Claude FAIL on fdcb release-note wording and three boot fixtures missing sheet nodes, with eight repairs assigned. Independent source review of fdcb..2fabd41/treead16f8cec9c81f539b0a63f7a26259c46260f5f7 closes those two concerns: notes name Chat messages/Home CLI, both sections match with32entries/max484bytes, and all three fixtures supply the six actual sheet nodes. Other repairs and their execution checks, exact composition review, installed Mac continuity and Sasha UI approval remain open.

  7. andersalm commented on Oct 17, 2026

    @andersalm
    ContributorAuthor

    At fdb9d63 / tree 2d5d87da33a666e1e40dd9c5b0357f59c7cb9e27, an isolated probe of the committed module reproduces the 500 ms gesture-start gap in Chromium and WebKit: early pointer/Space presses open on late release, and held Enter repeats open. Both owner re-reviews pass their brief, but their synthetic click-time checks and excluded native browser runs leave this reproduced case open.
    A private one-file correction is ready for the source owner's review: bind pointer approval to its request and gesture start, retain keyboard eligibility through release, refuse repeat activation and reset state on lifecycle changes. All 32 isolated browser cases pass, including the original three failures, fresh late pointer/Enter/Space, held Space, fresh retries, focus-change, request replacement, untrusted-click and Cancel/Escape controls. Independent source/proof review, patch application, whitespace and syntax checks pass; source integration and installed Mac/Sasha acceptance remain open.
    Patch SHA256 b9c60f87f7057e15cb8de700be541310c047dd98a1f010ee8649bae25c79ec6a; assessment SHA256 ea7623e3ee48e3a3a073c5cbe9d288da53e997bd2f0f409849d4c16141c9150a. The assessment records a final harness bookkeeping error after results and cleanup were saved, plus the corrected scope/classifier interpretation; raw evidence is retained. Browser contexts and server closed, owned profiles and apply fixtures removed, and matching owned processes were absent.

  8. 18 remaining items

  9. andersalm commented on Oct 18, 2026

    @andersalm
    ContributorAuthor

    Gap found on Anders's installed alpha.23 Mac: Chat links are never clickable on a normal Home.

    • What Anders saw: Community messages example.com and https://example.com render as plain text, on the Mac and on the receiving Jetson.
    • Cause: with Community configured, Chat sends go through collaboration (gateway_room.rs:2045-2057), and every object is stored as Text with link: None (room_service.rs:2912-2946). Only local, non-collaboration mode creates Link objects (classify_object_body, :5311), which are the only ones Chat renders as clickable (chat-room-ui/src/lib.rs:4697-4729).
    • Effect: the required link sheet is unreachable from Chat on real Homes. Earlier smokes injected Link objects or used the Library frame. This is not a regression (same code path before).
    • No safety issue: nothing is clickable, so nothing opens.
    • Fix for alpha.24 (devil's advocate: MODIFY; branch fix/430-chat-text-links):
      • render http(s) URLs inside Chat text as links through the existing Home sheet, all text nodes, with no HTML or previews;
      • fail-closed activation in Home: no href at all, so no native navigation, middle-click or keyboard path; activation posts home:open-external, and a failure navigates nowhere;
      • the same rule for existing Link objects;
      • parser and activation tests, plus a Community-mode smoke;
      • Codex and Claude review; Sasha's acceptance on phones.
  10. andersalm commented on Oct 18, 2026

    @andersalm
    ContributorAuthor

    Unpublished implementation candidate 422ec37eddc3d7b3bd6ee73402da0fab90cb6a5d, tree 6c2ed90b05d31e0c8c3edc47c0c84367e9af1b10, has sole parent bfefe92f6; root verified local commit metadata. The owner reports text-link rendering, shared activation for Text/Link objects, and rebuilt Chat artifacts across six files.
    The owner reports 65 Chat tests, fmt/clippy, five artifact tests and the selected native-input smoke PASS. Cross-family code review started at 22:09 UTC and remains pending; these results describe the source candidate.
    Independent evidence audit of that commit's scripts/chat-room-configured-layout-smoke.mjs:310–339: synthetic configured poll and a stand-in Home record four bridge requests. Installed Community send/receive, the real Runtime/Home confirmation, Cancel/Confirm, no opener, same-Home return and required phone acceptance remain open.

  11. andersalm commented on Oct 19, 2026

    @andersalm
    ContributorAuthor

    Codex reviewed cdb5375dad1d34fccc073ae8164b56b847f7750d against 422ec37ed: PASS. Together with the earlier PASS on 422ec37ed, this covers both Chat link commits by source inspection.
    Claude’s review is PASS WITH CHANGES on those commits. OMP has assigned selection-without-opening, CJK URL handling and precise test names before merge; the resulting commit needs review coverage and rebuilt artifact checks.
    The author’s 66 unit tests, five artifact tests and four selected smokes are source/fixture evidence with synthetic Community data and a stand-in Home. Exact installed Community/DM → Runtime → Home Cancel/Confirm, same-Home continuity, emoji and phone acceptance remain open.

  12. andersalm commented on Oct 19, 2026

    @andersalm
    ContributorAuthor

    Codex PASS covers selection/CJK correction 5e7d77e7f8950ef9b0655287597a504b5ba91a05 against cdb5375da; its four stamp fields match by inspection. The reviewer ran no builds or tests. This extends the earlier source reviews, while installed link and phone acceptance remain open.
    New DM-note commit 2d12f7f68fd0087ee9ab43d62d70c8b4a6ceb36e has author-reported 68 unit tests plus artifact/fixture checks. Codex FAIL found four blockers: unchanged polls can leave the note hidden, browser and Runtime clocks differ, removed contacts are excluded from Runtime retry, and a missing receipt proves delivery is unconfirmed.
    OMP has assigned a new correction commit with a threshold timer, one monotonic browser clock, contact-aware retry text and “Delivery unconfirmed” wording. The corrected head needs review and checks; real Community/DM → Runtime → Home Cancel/Confirm, return to the same Home, emoji and Sasha’s phone checks remain required.

  13. andersalm commented on Oct 19, 2026

    @andersalm
    ContributorAuthor

    Codex delta review PASS WITH CHANGES at c27f4ece32b3e6828916bf19fe1fbfb163df8c51 closes all four earlier DM-feedback blockers: the unchanged-message wake-up, clock basis, removed-contact retry claim and missing-receipt wording.
    Nonblocking notes remain for first-seen-map retention, own-send timing and the Shared-view timeout. Source fingerprint and committed browser assets agree; a different default local compiler WASM leaves complete build-output parity unverified and needs the correct producer receipt.
    This improves feedback, while the reported Anders-to-Sasha DM transport/receipt failure in #86 remains separate. Exact installed Community/DM-to-Runtime/Home link checks, same-Home continuity, emoji and phone acceptance remain open.

  14. andersalm commented on Oct 19, 2026

    @andersalm
    ContributorAuthor

    Chat links, review closure. Branch fix/430-chat-text-links, base bfefe92f6.

    Commit What Codex Claude
    422ec37ed http(s) in Text renders as links; no href inside Home; fail-closed activation PASS PASS WITH CHANGES (below)
    cdb5375da DMs too; linear trimming; Link-card label PASS (same review)
    5e7d77e7f Claude fixes: selection guard, honest test names, CJK boundaries and punctuation PASS –
    2d12f7f68 Pending-DM note and Retry feedback (#86) FAIL, 4 blocking –
    c27f4ece3 Fixes: render timer, one clock, no retry claim for removed contacts, "Delivery unconfirmed" PASS WITH CHANGES –

    Dispositions of non-blocking notes:

    • Claude Closed: void review surface #4: focus is lost after a failed activation outside Home framing. Rejected: rare, and the existing re-render already does the same.
    • Codex c27f: the first-seen map is not evicted for IDs that vanish. Rejected: it is bounded by the DM IDs seen in one page session.
    • Codex c27f: an extra single timeout after switching to Shared. Rejected: it fires once and clears.
    • Codex c27f: own sends start timing at first render, not at send. Accepted as is: equivalent within a poll.
    • Codex c27f: the local compiler WASM hash differs from the stamp. The committed browser assets match the stamp, and CI's artifact check is the gate.

    Author checks at c27f4ece3: 69 chat-room-ui tests pass; fmt and clippy (native and wasm32) clean; artifact check matches; smokes external-link-via-home and direct-* pass. A mutation check confirmed the render timer is load-bearing.

    Integrated in the alpha.24 train (release/train-0.8.0-rc9).

    Still open: the installed Community and DM link journey with Cancel/Open on the qualified candidate (Codex, Mac), and Sasha on phones. Sasha also reviews the note text and the "Trying again" label.

  15. modified the milestones: 2.0.0, 2.0.2 on Nov 11, 2026
  16. andersalm commented on Nov 11, 2026

    @andersalm
    ContributorAuthor

    Reopened: the code shipped in 2.0.0, but the installed check in Done means was never recorded, and AGENTS.md closes a task only when Done means is proven. The check is owed in 2.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions