Repository navigation
Conversation
The install transaction renames the staged binary onto the installed path. On Linux the running path then ends in " (deleted)", and the watch exits 75 so a supervisor can start the gateway again. A move, an unreadable path, or a failed re-hash waits for one more sample. A second sample with the same failure exits 1 and names the recovery command. The failure text does not contain "changed on disk". Co-authored-by: Sash <SashaMIT@users.noreply.github.com>
066116f to
c7592e8
Compare
…-1297 Brings in the zip 9 merge, the journal test cherry-pick and the lock ownership fix 3672007 from the base branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6Qn9RX7LDqrwiAfNC2F2K
The contract says a second sample with the same failure exits 1, but the watch kept one shared pending flag, so an unreadable file followed by a move, or moves to two different paths, also exited 1. The watch now records which failure it saw (and, for a move, the new path). Only the same failure on the next sample stops; a different one waits again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6Qn9RX7LDqrwiAfNC2F2K
|
Generated by Claude Code |
|
Round 3 review: PASS (B+). |
Brings in #394 4bb19dc: one-step flock ownership proof, the subordinate lane on the same proof, and a held lock with an unreadable record counting as held. host_lock.rs merged without conflict. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6Qn9RX7LDqrwiAfNC2F2K
|
Round 4 at 27432f0: PASS (B+). Same-failure rule proven; CI green. |
Brings in #394 13cdcad: the launcher contract states that the host lock proves possession, not that the holder is the gateway, also for the inherited ELASTOS_GATEWAY_HOST_LOCK_FD, with two process tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6Qn9RX7LDqrwiAfNC2F2K
|
CI on ccd860f (run 39092041888): only Generated by Claude Code |
Brings in #394's head d30027e, which merges develop at bfefe92 (develop's fix for its own #430 Home link test). No conflicts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6Qn9RX7LDqrwiAfNC2F2K
|
Generated by Claude Code |
Summary
The install transaction replaces the installed binary by renaming the staged file onto that path. On Linux the running path then ends in
(deleted). The binary watch exits 75, and a supervisor startselastos gateway --addr localhost:8090again.A moved path, a path that cannot be read, and a failed re-hash wait for one more sample. A replacement on that next sample exits 75. A second sample with the same failure exits 1. A different failure on that next sample, or a move to a different path, waits for one more sample instead (
2efbfbf3): the watch records the failure it saw (WatchFailureinhost_lock.rs: path unreadable, moved to a named path, unverifiable, re-verify failed) in place of the earlier sharedpending_confirmflag, which let two different failures in a row exit 1. The message nameselastos gateway --addr localhost:8090. That failure text does not containchanged on disk. A supervisor leaves that process stopped.Head
ddf4344e. Draft. Do not merge. Stacked on #394: this branch merges #394's head36720070(290a7401, a merge, no rebase), which carries the zip 9 merge, the cherry-pick of develop50515055and the/healthzlock-ownership fix. It then merges #394's head4bb19dcf(27432f02, a merge, no rebase;host_lock.rs,runtime_control.rsandgateway_home_terminal.rsauto-merged). In it, the ownership proof is one step (each registry entry keeps a second descriptor of the locked open file, and the registry mutex is held from the lookup to the end of the probe;85f3142e); the managed-runtime subordinate lane uses the same proof as/healthz, and a Home terminal gets an inherited lock descriptor,ELASTOS_GATEWAY_HOST_LOCK_FD(eed83a72); a held lock whose record cannot be read still counts as held (4bb19dcf). It then merges #394's head13cdcad0(ccd860f8, a merge, no rebase;docs/LAUNCHER_CONTRACT.mdandhost_lock.rsauto-merged, no conflict): the contract states that the host lock proves possession, not that the holder is the gateway, also forELASTOS_GATEWAY_HOST_LOCK_FD, with two process tests (docs and tests only). It then merges #394's headd30027ed(ddf4344e, a merge, no conflict), which merges develop atbfefe92f. The diff of this PR against its base isc7592e89(exit 75 meanings) and2efbfbf3(same-failure confirmation).Tests
cargo test -p elastos-server --lib host_lock:: healthz gateway_inside_serveon2efbfbf3: 23 passed, including a rename onto the running test binary (exit 75), one metadata miss then new bytes (exit 75), a failed re-hash that exits 1 on the second sample without the wordschanged on disk, andsupersession_watch_confirms_only_the_same_failure_twice: an unreadable file, then a move, then a move to another path each wait (no exit), and the same move on the next sample exits 1 and names that path.Negative proof: with the confirmation check reverted to the old meaning (
if self.pending_failure.is_none(), i.e. any pending failure confirms, inconfirm_stop), that test fails:panicked at crates/elastos-server/src/host_lock.rs:1022:9: a move after an unreadable file is a different failure. With the fix it passes.cargo clippy -p elastos-server --all-targets -- -D warnings,cargo fmt --all -- --checkandgit diff --checkpass. Run on a Linux worker only.On
27432f02:cargo test -p elastos-server --lib(host_lock,runtime_control::tests::subordinate,site_publication::test_healthz) 35 passed;cargo fmt --checkOK;cargo clippy -p elastos-server --all-targets -- -D warningsclean.On
ccd860f8:cargo test -p elastos-server --lib -- host_lock:: possession home_terminal_lane subordinate_lane healthz gateway_inside_serve32 passed, 1 ignored (the child half of #394's subprocess test, which its parent test runs), built from this worktree;cargo fmt --all -- --checkOK. Clippy was not re-run on this merge.On
ddf4344e: the same test filter 32 passed, 1 ignored;cargo clippy -p elastos-server --all-targets -- -D warningsclean;cargo fmt --all -- --checkandgit diff --checkpass. Built from this worktree.CI
ccd860f8): attempt 1 failedsource-home-linux (ubuntu-24.04)atinstalled Marketplace Get and Assistant reply(Installed journeys in source-home-linux (ubuntu-24.04) fail intermittently, on develop too #433). Attempt 2 was a failed-jobs re-run, more than a day later, that failed atdownload pinned AMD64 engine inputwithArtifact not found for name: llama-amd64-bundle. The bundle is uploaded withretention-days: 1and that job was not re-run, so the journeys never ran (installed journey acceptance is incomplete). This was not a code failure.ddf4344estarts a fresh full run.Principles check
docs/LAUNCHER_CONTRACT.mdon this branch states the exits these tests lock, including that a different failure waits again.Intel stays C. This pull request publishes no Intel download. No grade here is a merge approval.
Team issues to open
Refuse an unsigned binary before a supervisor restarts it. Body: Exit 75 tells the supervisor to start the gateway again after a hash change. The watch does not verify those new bytes against the signed manifest. Gateway start, or the supervisor, must refuse an unsigned replacement and show that refusal.Adversarial review for launcher process control. An independent review from a non-Cursor model family, thenirzhywau, on this SHA.