Skip to content

Retire superseded Browser observations and verify lifecycle recovery - #420

Draft
SashaMIT wants to merge 8 commits into
developfrom
fix/review-browser-lifecycle
Draft

SashaMIT wants to merge 8 commits into
developfrom
fix/review-browser-lifecycle

Conversation

@SashaMIT

@SashaMIT SashaMIT commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Browser observations belong to the run that started them. Retired polling, input refresh and heartbeat results preserve the newer run. Already dispatched effects keep their existing ownership.

Both lifecycle Chromium smokes run in scripts/test-behaviour.sh with pinned Playwright. Runner tests check invocation and failure propagation. The base merge adopts develop's Library Home-link fixture.

At prior head 9fc519f9, the manual gate and unchanged push hook passed both real Chromium smokes:

node scripts/browser-window-close-headless-smoke.mjs
node scripts/home-browser-restored-lifecycle-headless-smoke.mjs

Earlier runner tests passed 8/8; separate removal of either smoke invocation or the required Playwright export caused assertion failures. These controls remain historical evidence.

Candidate: 8c27d0e6d4449e9a662df25c808b91b6a2a51ce9; merged develop: c97c549e20e0851b417447af9509b25a30c23f06. Required local checks: manual just ci-local-prepush and actual unchanged push hook PASS; both lifecycle Chromium smokes passed in each. Hosted CI: completed cancelled; Linux x86-64 model retry timed out after controller restart passed. Exact cause remains under #433 investigation.

Prior-head Claude review records PASS at 9fc519f9. Independent source-continuity review passed: the reviewed ancestor and all seven owned path contents are preserved. The current-head Claude re-review records PASS at 8c27d0e6; the linked earlier verdict remains historical evidence. Installed Browser/media acceptance remains pending.

Prior-head CI attempt 2 at 9fc519f9 passed: 15 successful jobs and one configured skip. #433 retains the earlier failure and unresolved cause. The new head’s push hook checked compatibility with later develop 3a043849; its merged base remains c97c549e.

Review order: #420 → #421 → #424 → #416 → #411 → #412 → #428. #417 owns ZIP remediation. Draft; target develop.

Review package extracted from preserved candidate b0fa431d. The original eighteen commits remain on fix/runtime-performance-080. Validation of this recomposed head is recorded separately from historical candidate evidence.
@SashaMIT

Copy link
Copy Markdown
Contributor Author

Independent review (Claude) of ffd7694: PASS. The run-token fix holds; reverting it fails all 24 new tests.
Follow-up: add the two Browser headless smokes to a gate.

Copy link
Copy Markdown
Contributor Author

Head 9a86d3aed0ba5f0e9d9580fad97c7a1fcb7b3616. Ready for Sasha’s Claude review of this head.
Both Browser lifecycle headless smokes now run in the behavior gate; proof: node --test scripts/test-behaviour.test.mjs, each removed-call check, and both real headless smokes in just ci-local-prepush.
CI started: https://github.com/Elacity/elastos-runtime/actions/runs/39042006649. Code checks are queued.

@SashaMIT

Copy link
Copy Markdown
Contributor Author

Review at 9a86d3a: PASS (A). Both lifecycle smokes gated; 3 tampers caught; all real CI jobs green.

Preserve the existing review history and include current develop 8ea4aac. Refresh through the reviewed parent branch where that dependency applies.

Co-authored-by: Codex
Apply the test-only System fixture from 619c096 to the refreshed develop base. Preserve the existing authority assertions and production behavior.

Co-authored-by: Codex
Preserve the reviewed task changes and integrate the current development base through a normal merge.

Co-authored-by: Codex
Use the upstream Library fixture and preserve the branch feature changes.

Co-authored-by: Codex

Copy link
Copy Markdown
Contributor Author

Ready for Claude review at 9fc519f98ebdc5df2b14ac2fcee4998cae181f1b.
Merged current develop with the Library Home-link fixture; browser-window-close-headless-smoke.mjs and home-browser-restored-lifecycle-headless-smoke.mjs passed in real Chromium during both required local checks.
CI has started: https://github.com/Elacity/elastos-runtime/actions/runs/39096454267

@SashaMIT

Copy link
Copy Markdown
Contributor Author

Round 6 at 9fc519f: PASS (A). Own diff unchanged since round 4; tampers caught; no failed CI job.
Blocker: source-home-linux needs a re-run (known #433).

Copy link
Copy Markdown
Contributor Author

Updated head: 8c27d0e6d4449e9a662df25c808b91b6a2a51ce9.
Manual just ci-local-prepush and the actual unchanged push hook: PASS on this head.
CI has started: https://github.com/Elacity/elastos-runtime/actions/runs/39223916041. Source-continuity review: PASS; Claude PASS remains at prior head 9fc519f9.

@andersalm

Copy link
Copy Markdown
Contributor

0.8.0 batch integration (OMP): 8334ecae's browser.js fix and its two node test files are taken as 60b2e52ce on fix/080-batch-sasha-prs. The two headless smoke rewrites and 9a86d3ae (gate wiring) are deferred to after 0.8.0 (the CI batch, #310), because new gate suites in the final week add flake risk. Codex review is pending.

@SashaMIT

Copy link
Copy Markdown
Contributor Author

Re-review (Claude) at 8c27d0e: PASS (A carried). One clean develop merge (c97c549); empty remerge-diff, own patch unchanged.
x86 installed journey fails at model_interrupted_get_retry/restarted_home (#433: Home ready, Marketplace window not shown); #424 passes it with this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants