Repository navigation
Assistant: the reply stays above a growing follow-up composer - #545
Merged
Merged
Conversation
Remove the time-based observer disconnect: unchanged geometry calls can consume its burst budget and leave a grown follow-up composer covering the reply. Keep the measured-value check and per-frame re-entry guard. Pinned Chromium at CPU rate 6 reproduced persistent -64px overlap on the unchanged product. The geometry-burst regression failed 3/3 before and passed 10/10 in the candidate pilot. Preserve all existing assertions and record geometry and assertion timing for further failures. Full behaviour and source gates follow on this commit.
Review note on ec11ec6: the smoke switched to playwright-core 1.59.1 (Chromium 1217) unlike the other Assistant smokes; the 5 Nov failures ran on the fixture's Chromium 1223. Main (Claude) restored the import; the smoke passes at CPU rates 1 and 6.
Contributor
Author
|
Merged for 2.0.1. Reviews: Claude PASS on ec11ec6 (cause reproduced, guard's loop cannot recur, reader position kept, #533 behaviour unchanged). Main restored the shared-fixture Chromium import in the smoke after review (smoke passes at CPU rates 1 and 6). CI 15/15. The separate 'Jump to latest' flash is recorded on #527. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deepen notes
scripts/assistant-reply-layout-browser-smoke.mjsfailed on 5 Nov on feat/201-channel-choice and fix/201-browser-open-reason (abovePx=-64while typing a follow-up);capsules/assistant/browser/agent-harness.jscomposer clearance observer.Change
Separate, still open: "Jump to latest" can show for 1 to 2 frames to a reader who never scrolled up, under load (reviewer: 5 of 30 before, 1 of 30 after); recorded on #527.
Release issue #535.