Skip to content

CI census: an exited child waiting to be reaped is not an escape (#433) - #549

Merged
andersalm merged 1 commit into
developfrom
fix/433-census-zombie
Nov 6, 2026
Merged

andersalm merged 1 commit into
developfrom
fix/433-census-zombie

Conversation

@andersalm

Copy link
Copy Markdown
Contributor

Deepen notes

  1. Expert view: a process census should not call an exited process waiting to be reaped an escape, while every real escape and the final whole-unit exit proof stay.
  2. Raw material: the CI reliability: the census names the child that left its unit (#433); Assistant keeps the finished reply in view #533 diagnostics on CI run 42188746234 (Installed journeys in source-home-linux (ubuntu-24.04) fail intermittently, on develop too #433 comment): llama-server pid 60006 in state S, then 109 ms later the same pid and start ticks in state Z, no longer in the unit's cgroup.procs, parent still alive in the unit.
  3. Methods: read state and start ticks from one bounded /proc/<pid>/stat sample; fixture /proc data for zombie, running escape, reused pid and unreaped zombie.
  4. Independent check: the zombie regression fails on develop with the CI message and passes after; running escapes and reused pids still fail; an unreaped zombie still fails final cleanup. Main (Claude) reviewed the diff (stat field indexing: state is field 3, start time field 22).

Change

CI harness only (scripts/ci-installed-journeys.py): a retained child that has exited and waits for its parent (state Z, same start ticks) is not counted as a live child outside its unit. Linux removes an exited task from cgroup.procs before the parent reaps it, which made the census report finite journey live child left its unit census. The pidfd stays for the existing whole-unit exit check.

Fixes #433.

@andersalm
andersalm merged commit f50e448 into develop Nov 6, 2026
16 checks passed
@andersalm andersalm mentioned this pull request Nov 6, 2026
5 of 6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant