Repository navigation
Browser says how much space it needs; no engine text in open responses - #556
Merged
Merged
Conversation
Keep Browser Engine diagnostics private in the shared open-failure constructor, with a fixed public message and provider_error code. Preserve status classification and cleanup outcomes. Exercise a private path through a malformed engine receipt and the provider constructor. Drive refusal envelopes through real supervisor stderr and the control service HTTP response, including invalid codes and counts. Before/after: both Rust privacy assertions fail before and pass after. The transport tests fail on response assertions at 344284e (0/7 pass) and pass here (7/7). Validation: - cargo fmt --all -- --check; chain-provider cargo fmt -- --check - cargo clippy -p elastos-server --all-targets -- -D warnings - cargo test -p elastos-server --all-targets gateway_browser -- --nocapture: 228 pass - Browser Node tests: 1280 pass across 72 files - ./scripts/test-source-gate.sh: pass; 2 Linux pidfd checks skipped on macOS - ./scripts/test-behaviour.sh: 2189 pass - node --test scripts/check-product-data.test.mjs: 105 pass - git diff --check
Keep Runtime profile-placement refusals typed through Engine selection so Browser receives the existing transfer instructions. Retain Engine open diagnostics in private warnings with their HTTP status. Cover the foreign-placement route response, provider text that imitates transfer guidance, and log capture in an isolated test process. Preserve the existing Mac overlay boundary and error status classification.
Restore Runtime-authored sign-in errors and plain open-job admission conflicts. Keep fixed Exit reasons and viewer-ingress guidance, log request and Runtime admission rejections at debug, and preserve remote preparation error chains. Test the route bodies with the real Browser consumers, including sign-in expiry after gateway admission.
Restore full private Runtime diagnostic chains at the single failure projection. Warn for fallback faults and keep specific Runtime refusals at debug. Preserve fixed public copy for a selected Exit node host-policy refusal. Regression evidence: 7 passed / 2 failed before; 9 passed after. Both pre-effect and post-cleanup audit failures log their cause exactly once at WARN. Checks: workspace and chain-provider fmt; server all-targets Clippy with -D warnings; server lib (3297 passed, 27 ignored), bin (217), integration (1); Browser Node (1284); source gate and behaviour (2199); git diff --check. All Cargo and suites ran through elastos-heavy.
Contributor
Author
|
Bounded source PASS: the typed space refusal, public error projection and cleanup ownership changes preserve the reviewed Browser boundaries. |
Contributor
Author
|
Merged for 2.0.1 at 801cd98. Codex Root bounded SOURCE PASS on 801cd98 (comment 6690804276) after five Claude rounds and a Claude PASS on the #551 merge resolution (81b77ff). Full Linux check PASS on 801cd98. CI 15/15 after one rerun of source-home-macos, which GitHub never started (no macOS arm64 runner acquired). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deepen notes
browser-vz-engine-supervisor.rs,browser-vm-control-service.mjs, the engine adapter,gateway_browser.rs,browser-status.js.Change
Separate, pre-existing: #550 (front door answers an already-expired token with a generic 403).
Part of #90. Release issue #535.