Repository navigation
System update shows download progress and release notes; one size formatter (#577) - #595
Merged
Merged
Conversation
…#577) The compact model view put its live region beside the Status list, so a model detail carried a section the app detail does not have. The consumer now names the live-region host: Marketplace gives the dialog, which outlives each detail render and stays inside the modal a screen reader reads. Closing the view clears the region, so a later detail starts silent. Co-authored-by: Cursor <cursoragent@cursor.com>
…#577) The layout smoke now runs the model detail with a download in progress. It requires one polite live region, outside the sections a model shares with an app, and an empty region after the detail closes. Co-authored-by: Cursor <cursoragent@cursor.com>
Review findings. A screen reader reads a live region that already exists when its text changes, so the view creates it empty at mount. The smoke now requires the region inside the dialog, and the fixture answers a status poll that is still in flight when the detail closes. Co-authored-by: Cursor <cursoragent@cursor.com>
… text (#577) A screen reader can skip a live region that enters the page with text already in it, and only the first model detail of a page can show that the view opens the region empty: the modal keeps the region after a detail closes. The smoke now holds that detail's catalog read, requires one empty region in the dialog, then releases the read and requires the region to stay empty with no download. Co-authored-by: Cursor <cursoragent@cursor.com>
The 28 Oct decision keeps the post confirmation to the file name in its title and one line of body. Restore that line and pin the size wording on the phases that show the posted text. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
2 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deepen notes
update.rs(plan and canonical install path),update_controller.rs(progress file, lease, cleanup),capsules/_shared/byte-format.jsandtransfer-progress.js, andcapsules/system/browser/(the update card).5cab6ff21(and on each earlier round); Opus reviewed as the second reviewer for the update path. Two fixes after the first CI run (the Marketplace download announcement and the Chat post confirmation) were written with Claude and reviewed by GPT: PASS at6a77f7972.What changes
system_update_with_symlinked_binary_parent).elastos updatein Terminal keeps develop's exact order and output. A System update reads only the signed component list early (for the total) and downloads no component payload until the binary is verified (tampered_binary_precedes_other_downloads…).Known limits
Part of #577 (phase 2, the same bar for app first-open, shared files and Browser Engine preparation, follows in its own PR).