Skip to content

System update shows download progress and release notes; one size formatter (#577) - #595

Merged
andersalm merged 75 commits into
developfrom
feat/577-download-progress
Nov 14, 2026
Merged

andersalm merged 75 commits into
developfrom
feat/577-download-progress

Conversation

@andersalm

@andersalm andersalm commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Deepen notes

  1. Expert view: progress is advisory. It must never change what an update downloads, verifies or installs, and the numbers on screen must be honest at every boundary.
  2. Raw material: update.rs (plan and canonical install path), update_controller.rs (progress file, lease, cleanup), capsules/_shared/byte-format.js and transfer-progress.js, and capsules/system/browser/ (the update card).
  3. Methods: regression tests that fail on the pinned source for every review note, real-capsule Chromium tests, Linux Cargo tests on rented boxes, Mac behaviour and source gates, and screenshots checked by eye.
  4. Independent check: Claude Fable 5.2 PASS and Claude Opus 5.5 PASS on 5cab6ff21 (and on each earlier round); Opus reviewed as the second reviewer for the update path. Two fixes after the first CI run (the Marketplace download announcement and the Chat post confirmation) were written with Claude and reviewed by GPT: PASS at 6a77f7972.

What changes

  • System update card: "Update to X" until the owner approves, then "Updating to X", a bar with "X of Y · N%", the signed release notes ("What's new"), visible while downloading, then the publisher and the button. No separate current or new version lines.
  • One formatter for sizes everywhere (1000-based; GB with two decimals), with a guard against a second copy. The percent follows the true bytes and reads 100% only when every byte has arrived. An unknown total shows "X received · Size unknown".
  • Fix: System update failed on Macs whose install path goes through a symlink (the path is canonicalised before the early read; system_update_with_symlinked_binary_parent).
  • Advisory progress: writes at most once a second without fsync. A failed write or read is ignored. A damaged progress file never hides or blocks an update. Orphan temp files are removed under the controller lease.
  • The Runtime binary is verified before anything else is fetched. elastos update in Terminal keeps develop's exact order and output. A System update reads only the signed component list early (for the total) and downloads no component payload until the binary is verified (tampered_binary_precedes_other_downloads…).
  • Text other Homes read is unchanged: Community file posts keep develop's exact size wording ("4 bytes"), pinned by a test, and the sender's post panel states the file size in that same wording after the post. The confirmation still names the file in its title and asks with one line.
  • Screen-reader announcement: a running model download is announced politely from the Marketplace dialog, so a model detail and an app detail keep one structure.

Known limits

  • The download plan is built before Home repairs its installed support, so on a damaged Home one cached app can stay on its older version, or one asset can be fetched twice (signed rows still verify every byte).
  • The new bar appears on updates from 2.0.2 onward; the 2.0.1 → 2.0.2 update runs on 2.0.1's controller.

Part of #577 (phase 2, the same bar for app first-open, shared files and Browser Engine preparation, follows in its own PR).

@andersalm andersalm added this to the 2.0.2 milestone Nov 13, 2026
andersalm and others added 6 commits November 13, 2026 21:08
…#577)

The compact model view put its live region beside the Status list, so a model
detail carried a section the app detail does not have. The consumer now names
the live-region host: Marketplace gives the dialog, which outlives each detail
render and stays inside the modal a screen reader reads. Closing the view
clears the region, so a later detail starts silent.

Co-authored-by: Cursor <cursoragent@cursor.com>
…#577)

The layout smoke now runs the model detail with a download in progress. It
requires one polite live region, outside the sections a model shares with an
app, and an empty region after the detail closes.

Co-authored-by: Cursor <cursoragent@cursor.com>
Review findings. A screen reader reads a live region that already exists when
its text changes, so the view creates it empty at mount. The smoke now requires
the region inside the dialog, and the fixture answers a status poll that is
still in flight when the detail closes.

Co-authored-by: Cursor <cursoragent@cursor.com>
… text (#577)

A screen reader can skip a live region that enters the page with text already
in it, and only the first model detail of a page can show that the view opens
the region empty: the modal keeps the region after a detail closes. The smoke
now holds that detail's catalog read, requires one empty region in the dialog,
then releases the read and requires the region to stay empty with no download.

Co-authored-by: Cursor <cursoragent@cursor.com>
The 28 Oct decision keeps the post confirmation to the file name in its
title and one line of body. Restore that line and pin the size wording
on the phases that show the posted text.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@andersalm
andersalm merged commit 297b598 into develop Nov 14, 2026
16 checks passed
@andersalm

Copy link
Copy Markdown
Contributor Author

Main: merged on Anders's explicit authorization in chat (14 Nov 2026). Required checks green on 6a77f79.
Review: Claude Fable 5.2 and Opus 5.5 PASS on 5cab6ff, Fable PASS on 6bd92db, GPT PASS on 6a77f79 for the two fixes after the first CI run; unchanged in between apart from merges of develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant