Repository navigation
Conversation
… without repeated SDK hashing
…principal or payload
Open
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deepen notes
f6b2562fd:capsules/wallet-walletconnect/browser/wallet-walletconnect.js:40-63,walletconnect-client.mjs:82-134,elastos/crates/elastos-server/src/api/gateway_walletconnect.rs:410-425,507-564; installed A/B HTTP recordings preceded edits. The original walk recovered in newly opened windows.6f7c1d9f0, treee9866480afce8b7bfc8e158bbe75b1fb76df0af6: 188/188 narrow cases with 186 unchanged names and two stronger return assertions; 110/110 product-data cases; syntax, format and launch smoke PASS. Exact-head Linux format, all-target server Clippy and WalletConnect tests PASS (438 s). Final return/launch checks PASS 20/20, including a held off-state reply across Allow. Current local development and adversarial source reviews PASS. Fresh installed acceptance and publication remain with Main.Earlier implementation notes (through round 13)
These notes retain the broader feature context and earlier evidence. Current-candidate verification is above.
Deepen notes
e5772eaa5,capsules/wallet/browser/wallet-requests.js:179,elastos/crates/elastos-server/src/api/gateway_wallet_connectors.rs:307-413, and the complete Fable and Opus round-12 reviews.1c9cf51852(tree897053a22f). Main holds the private receipts and owns current-head review and hosted CI after publication. The round-12 Fable/Opus PASS verdicts covere5772eaa5.Draft: not for merge yet
Open as a draft so CI runs and the work is visible. Before it is ready: Irzhy's review of the network and session boundary (#575 says this comes first), the independent review of the latest commits, and Anders's trial with a real phone wallet.
What changes
Proven
Known limits
Part of #575.