Skip to content

Bump zip to 9.0.5 for RUSTSEC-2026-0548 (lockfiles only) - #601

Merged
andersalm merged 1 commit into
developfrom
fix/zip-9.0.5-audit
Nov 17, 2026
Merged

andersalm merged 1 commit into
developfrom
fix/zip-9.0.5-audit

Conversation

@andersalm

Copy link
Copy Markdown
Contributor

Deepen notes

  1. Expert view: CI audits lockfile versions, not what the code calls. Clear the advisory range with the smallest change, and state separately whether the affected reader is reachable.
  2. Raw material (at develop 5075c84765): RUSTSEC-2026-0548 covers zip below 9.0.5 (ZipStreamReader can extract entries under local-header names that differ from the central directory). elastos/Cargo.lock and capsules/object-provider/Cargo.lock pin zip 9.0.4; elastos/crates/elastos-server/Cargo.toml:103 declares zip directly. The Library readers in elastos/crates/elastos-server/src/library.rs (lines 5060, 5267, 5827, 6406) open archives with ZipArchive and read entries by index. A search of the Rust sources finds no use of ZipStreamReader or read_zipfile_from_stream.
  3. Methods: cargo update -p zip --precise 9.0.5 for each affected lockfile; CI's audit loop over all 34 tracked lockfiles; a read of zip 9.0.5's changelog and stream reader.
  4. Independent check: with the same advisory database, both base lockfiles fail on RUSTSEC-2026-0548 and all 34 lockfiles on this branch pass. The full Linux check passed on this head (gate, test-elastos, test-capsules, built with --locked). A review by a different model family returned pass with notes, and a second source read confirmed the lock delta and matched the new checksum to the registry. Not verified: the reviewer could not download the published crate or refresh metadata offline, so a full diff of the published 9.0.4 and 9.0.5 crates was not made.

Change

  • zip 9.0.4 to 9.0.5 in elastos/Cargo.lock and capsules/object-provider/Cargo.lock. Three lines change in each: zip's version and checksum, and one dependency line of data-encoding-macro-internal that the resolver moves from syn 3.0.x to syn 2.0.119 (inside its accepted range; both lockfiles already carry syn 2 and 3). No manifest changes.
  • The advisory's fix in 9.0.5 is a header consistency check that is off by default, and this repository does not call the stream reader, so this bump clears the advisory range without switching that check on. 9.0.5 also carries upstream fixes for BSD permission handling and duplicate AES extra fields; the archive paths traced here use neither. This is a statement about reach from a source search, not a full review of archive extraction.
  • Released 2.0.1 keeps zip 9.0.4.
  • Until this is on develop, the audit job fails on every pull request and the cancel-on-failure job stops the rest of the run.

No issue is closed by this; the pull request is the record.

Lockfile-only change in elastos/Cargo.lock and
capsules/object-provider/Cargo.lock: zip 9.0.4 to 9.0.5. No manifest
changes. The advisory concerns ZipStreamReader, which this repository
does not call; the bump is needed because CI audits lockfiles.

Refs #569

Built-by: Claude
@andersalm
andersalm merged commit f6d8195 into develop Nov 17, 2026
16 checks passed
@andersalm

Copy link
Copy Markdown
Contributor Author

Main: merged on Anders's explicit authorization in chat (17 Nov 2026); required checks green on b64f267.
Review: GPT pass with notes on the same commit, and the lockfiles are unchanged since. Released 2.0.1 keeps zip 9.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant