Repository navigation
Add the DE SpotNet spot detector and center refinement networks - #25
Merged
Merged
Conversation
…tworks Six kind: weights entries for Direct Electron's networks, served as ONNX graphs from Zenodo record 23383572 (CC BY-NC 4.0): four spot detectors (DE_SpotNet, DE_SpotNet_Dynamical, DE_SpotNet_Production, DE_SpotNet_Base16) and the two center refiners that follow them (DE_CenterNet, DE_FriedelNet). The matching torch checkpoints sit in the same record for training and fine-tuning.
dataset_files sorted Path objects, and Windows paths compare case-insensitively, so a stub generated on Windows put LayeredCuNb4DSTEM before LSMOLineScan and failed the stub check on Linux CI. Sort on the POSIX path string instead, which is the order CI already produced.
One *_Torch entry per network for the .pt checkpoints in the same Zenodo record, which training and fine-tuning start from (quantem's teach-on-your-marks needs them). Each ONNX entry now names its _Torch partner and vice versa.
Contributor
Author
|
@arthurmccray do you want to review this? Not sure exactly how we should be distributing these. The ONNX models are nice so they aren't so tied to pytorch |
Collaborator
|
yup I'll try and get to it today! |
arthurmccray
approved these changes
Oct 16, 2026
arthurmccray
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, zenodo is down (again) but I trust all the links will work when it's back up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Direct Electron's diffraction spot (Bragg disk) networks as twelve
kind: weightsentries (each network as an ONNX graph and as a torch checkpoint), served from Zenodo record 23383572 (DOI 10.5281/zenodo.23383571), licensed CC BY-NC 4.0.DE_SpotNetde_spotnet.onnxDE_SpotNet_Dynamicalde_spotnet_dynamical.onnxDE_SpotNet_Productionde_spotnet_production.onnxDE_SpotNet_Base16de_spotnet_base16.onnxDE_CenterNetde_centernet.onnxDE_FriedelNetde_friedelnet.onnxDE_CenterNetmodel.framework: onnx,model.class: onnxruntime.InferenceSession), so pyxem and quantem can run them without torch._Torchpartner (DE_SpotNet_Torch, ...,DE_FriedelNet_Torch) for the.ptcheckpoint in the same record (model.framework: torch), which training and fine-tuning start from. The descriptions cross-reference each pair."261015".get_diffraction_vectors(method="neural")) and quantem (BraggVectors.detect_disks(method="neural")).Checked locally:
--validatepasses for all twelve, the stub is regenerated (_create_stubs --checkclean), the test suite passes (376 passed), ruff and basedpyright are clean, and every entry downloads throughemdatabase.data.<Entry>().download(version="261015")with its md5 verified; the ONNX graphs run in ONNX Runtime.The second commit makes
dataset_filessort on the POSIX path string: WindowsPathobjects compare case-insensitively, so a stub generated on Windows putLayeredCuNb4DSTEMbeforeLSMOLineScanand failed the stub check on Linux.